From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 244EF3939C08 for ; Thu, 18 Jun 2020 12:50:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 244EF3939C08 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-s1Iv44FCMXmatu2LTbRghQ-1; Thu, 18 Jun 2020 08:50:18 -0400 X-MC-Unique: s1Iv44FCMXmatu2LTbRghQ-1 Received: by mail-qv1-f69.google.com with SMTP id q5so3977916qvp.23 for ; Thu, 18 Jun 2020 05:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TtS3GcGR0BYUlpD2edJNt4Q9l13w8ZoqEVyUvR8Kd+M=; b=X44KQjDchjKkdtjtNDVMDpLLO014guxNOct0P2gYf6wxKKALYXedZ5MK/Dj6WkI+kI Q3ssd+nDoMEqU++xj9fbVVodreo8c3pd/CmfsxLvM0ZG2foFuWalCm6o3oIXXRsti+wa vT40V4B+m860Vyt3+7z1lOQbNvWEBnhF664Y7/yscBOwmiwpEOMMPE29S7tF5WYPotBL DlVCMPbAgo/zLsUiaWOzan4vO9St2bMXh/2c2RpFP92jcClgA7OqrjqzkVx69aspPBuS ko/ReIHG6OaBIsEiDwBSj2XD/gSVu1trnPGl+C/j3CN4MZIjatlfu3TMaGeOMzqSDeAF q5vw== X-Gm-Message-State: AOAM532ci/m73KG81rIOU5tZa3UyEXiYXgpVlRsgb1lxJ4NgJJEf5GEr YniKuGbCkrU2kjUfg3AKuUK/v7Bv7YIRpKsxS/wtg6BopxNkIIyiTSQk7vD62XkGHfqGStl8xwj /BIpupqVlMZ13X7Ay188e X-Received: by 2002:a0c:e385:: with SMTP id a5mr3594016qvl.81.1592484617316; Thu, 18 Jun 2020 05:50:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4JCWi1PuYjJNdFEFoZgCLLcCZ+TNme9cMomGGWtIdwik8dP7n6rpLsNZFaUqiRSYkNjSILQ== X-Received: by 2002:a0c:e385:: with SMTP id a5mr3593999qvl.81.1592484616979; Thu, 18 Jun 2020 05:50:16 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id z194sm2913836qkb.73.2020.06.18.05.50.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 05:50:16 -0700 (PDT) Subject: Re: [PATCH v2 01/13] signal: Add signum-{generic,arch}.h To: Adhemerval Zanella , libc-alpha References: <20200603183444.587742-1-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat Message-ID: <8339f7fe-d982-f8bc-6d8c-16e8370bd967@redhat.com> Date: Thu, 18 Jun 2020 08:50:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200603183444.587742-1-adhemerval.zanella@linaro.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 12:50:21 -0000 On 6/3/20 2:34 PM, Adhemerval Zanella via Libc-alpha wrote: > It refactor how signals are defined by each architecture. Instead of > include a generic header (bits/signum-generic.h) and undef non-default > values in an arch specific header (bits/signum.h) the new scheme uses a > common definition (bits/signum-generic.h) and each architectures add > its specific definitions on a new header (bits/signum-arch.h). > > For Linux it requires copy some system default definitions to alpha, > hppa, and sparc. They are historical values and newer ports uses > the generic Linux signum-arch.h. > > For Hurd the BSD signum is removed and moved to a new header (it is > used currently only on Hurd). > > Checked on a build against all affected ABIs. The second patch in this series no longer applies cleany. Could you please rebase the patchset to v3 with your 2 v4 patches? I'll review after that. You're #2 in the queue. I'm going to review Szabolc's tls reservation patches now. -- Cheers, Carlos.