From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id DF37B3857C4A for ; Thu, 17 Mar 2022 06:22:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF37B3857C4A X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D835E861BF8; Thu, 17 Mar 2022 06:22:26 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8469A86188C; Thu, 17 Mar 2022 06:22:21 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1647498143; a=rsa-sha256; cv=none; b=tCYLIop449t7YfAU3PEDO5XmvoSuOU59Awgq4VVDPdoIsDsZRLvNV/GVJTjnAa3iJpNjNP xlHS/RKfhX7oRRghhsT2qk97R4quQSTCkLxBwtTfuh3Mr/g64aoEpIG3lGnVqn38zeDHZy lzGnThbWF9qtlLX4oAlYiFetrRs4TfDnqqFkqfhitPo4Vr2qV8ziXBEcYPkoKqduALCxes MA0vZGus90LUStNccgHpAE2rQUc7nNCNjtvjeNsYBy0Vt++Xk4bQl2+6u0JWF8QBZ2FhSn KlftU9MW+O23Gec61gf/ZuLzJFbnwbzecrt7bXLdg3TmB2gBqRGH2IjFn6NqTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1647498143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZRMgiKwl0nd8VcTRI2njQAA1xD2heit37FEcJncU93M=; b=0RX4caYdZVgnfjI1RESENMiz9P1sskPGp5j0EwAlAqD9nbZhaTpRxIhKjDmPU1RQWCCxDX CvVi91kQuJShCgxxbsiCmqEpLERxeFllzu+CwdO4fsSdxNiYPWjc70e8jaWm+GKTbI2VIg aHJU+/gutju08XiMd0JcKs2MCmqSfBUwh6+ZTrEkftMb4k+LHiepiSVFZBRVDeNwCazIJU gvmkbWOW4RNEhUMWKPwkGXNO/9BHZAExS8b9kDMcmk/CeN0prftch01ywx0OcMiGDRSq3F DTEopjg1jwYNZKHVfWSwZIBlssIEYQFWHVtOrTZ6J7ZewGCskscqFL33a8/gYQ== ARC-Authentication-Results: i=1; rspamd-c9cb649d9-g7mjj; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.102.3.17 (trex/6.5.3); Thu, 17 Mar 2022 06:22:26 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Trail-Dime: 3ced10b3337d171e_1647498144731_2286963559 X-MC-Loop-Signature: 1647498144731:239483478 X-MC-Ingress-Time: 1647498144730 Received: from [192.168.1.174] (unknown [1.186.123.88]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4KJxrJ4SSkz1b; Wed, 16 Mar 2022 23:22:08 -0700 (PDT) Message-ID: <835ae3ee-ceb9-9b1a-9ddb-734392d5186b@sourceware.org> Date: Thu, 17 Mar 2022 11:52:02 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 07/12] gaih_inet: Split nscd lookup code into its own function. Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3488.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 06:22:31 -0000 On 17/03/2022 10:01, DJ Delorie via Libc-alpha wrote: > > Siddhesh Poyarekar via Libc-alpha writes: >> Add a new member got_ipv6 to indicate if the results have an IPv6 >> result and use it instead of the local got_ipv6. > > One problem - need to clear res->got_ipv6 at some point (I couldn't find > a global "memset &res 0" that might indirectly clear it). I think once > you get a valid ipv6 response, it wlil get stuck set to true. I took a closer look at this and the nscd bit doesn't seem to need this; it's the nss code below that needs the initialization. I've fixed 1/12 to resolve it; 8/12 will then propagate it to gaih_result. Thanks, Siddhesh