From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 3E5553857C59 for ; Mon, 28 Sep 2020 05:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3E5553857C59 Received: by mail-wm1-x344.google.com with SMTP id b79so6084130wmb.4 for ; Sun, 27 Sep 2020 22:59:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JI2YTezJj4x2l7XXO9SBrjHgTd1v/ga7PlcE5RFGsFw=; b=rSag25JGeKXk5TZjI24lkGl2z9Cn+JE0pzyEr3EIIh/nbI1Nq5JFyqfF8hGUjJPz8o xzpnnYhLiuAA+cuOi3MHiabaGmSdzjK+ej4/TVwV/U6TiXnvXHIJ9FdwDwYtkW8yn+Cd U2Zowk0mRVB5ngdVMONzitAMp3ZruVZBIeM06GZsBJbHJDOudijJB/7+2PSMvPiEZT73 gWVZIwq2qNlySJ6Od3/L2P6qQnRpJL3Dvb3xbyPn8Uj7mwVkp+5Wdm/1lUyKhFPW32Xk oSXCE37V+Ef3qahxG2FqLrhc5S2V+Z+M6HDHKI01k2bzV8xYUXLVzr5NILNY0X3yGBZ5 /Aww== X-Gm-Message-State: AOAM532H5PmAMERPbE6zDdTQw36rQMCIJRASLbc+OTJwKWhw/VAgZ8Rz gHxLewj1UyguXDSvUW1VqoU= X-Google-Smtp-Source: ABdhPJyWybEufuvEuFK3IGvqc4ILKK7cd+g3iZC5VTNcnw6A+Xgs+RiAH07rsjuT0rbg8KJQ9psqAw== X-Received: by 2002:a1c:3505:: with SMTP id c5mr10292791wma.65.1601272758136; Sun, 27 Sep 2020 22:59:18 -0700 (PDT) Received: from ?IPv6:2001:a61:2479:6801:d8fe:4132:9f23:7e8f? ([2001:a61:2479:6801:d8fe:4132:9f23:7e8f]) by smtp.gmail.com with ESMTPSA id c16sm12746677wrx.31.2020.09.27.22.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 22:59:17 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org, "G. Branden Robinson" Subject: Re: [PATCH 1/3] system_data_types.7: ffix To: Alejandro Colomar References: <20200927211345.20433-1-colomar.6.4.3@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <836b6d7d-4433-18d0-78aa-542c419c02f2@gmail.com> Date: Mon, 28 Sep 2020 07:59:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200927211345.20433-1-colomar.6.4.3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2020 05:59:20 -0000 Hi Alex, On 9/27/20 11:13 PM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar I do think this requires an explanation saying what you are trying to do with this change (and then perhaps a more expansive "Subject" also). I can visually see what you are doing with this patch, but I do wonder if there is a better way of doing it. I've dropped Branden into CC. Perhaps he has a comment. Thanks, Michael > --- > man7/system_data_types.7 | 58 ++++++++++++++++++++-------------------- > 1 file changed, 29 insertions(+), 29 deletions(-) > > diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 > index 361e8d411..ff0403df9 100644 > --- a/man7/system_data_types.7 > +++ b/man7/system_data_types.7 > @@ -66,7 +66,7 @@ system_data_types \- overview of system data types > .TP > .I aiocb > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -101,7 +101,7 @@ See also: > .TP > .I div_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -125,7 +125,7 @@ See also: > .TP > .I double_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -167,7 +167,7 @@ type in this page. > .TP > .I fenv_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -184,7 +184,7 @@ See also: > .TP > .I fexcept_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -201,7 +201,7 @@ See also: > .TP > .I float_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -243,7 +243,7 @@ type in this page. > .TP > .I gid_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -280,7 +280,7 @@ See also: > .TP > .I id_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -304,7 +304,7 @@ See also: > .TP > .I imaxdiv_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -328,7 +328,7 @@ See also: > .TP > .I lconv > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -377,7 +377,7 @@ See also: > .TP > .I ldiv_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -401,7 +401,7 @@ See also: > .TP > .I lldiv_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -425,7 +425,7 @@ See also: > .TP > .I pid_t > .RS > -.PP > +.br > Include > .IR ; > or > @@ -481,7 +481,7 @@ See also: > .TP > .I ptrdiff_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -520,7 +520,7 @@ types in this page. > .TP > .I regmatch_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -545,7 +545,7 @@ See also: > .TP > .I regoff_t > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -577,7 +577,7 @@ types in this page. > .TP > .I sigevent > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -626,7 +626,7 @@ structure in this page. > .TP > .I siginfo_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -662,7 +662,7 @@ See also: > .TP > .I sigset_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -691,7 +691,7 @@ See also: > .TP > .I sigval > .RS > -.PP > +.br > Include: > .IR . > .PP > @@ -723,7 +723,7 @@ in this page. > .TP > .I size_t > .RS > -.PP > +.br > Include: > .I > or > @@ -846,7 +846,7 @@ types in this page. > .TP > .I ssize_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -922,7 +922,7 @@ types in this page. > .TP > .I suseconds_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -949,7 +949,7 @@ structure in this page. > .TP > .I time_t > .RS > -.PP > +.br > Include: > .I > or > @@ -992,7 +992,7 @@ See also: > .TP > .I timer_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -1015,7 +1015,7 @@ See also: > .TP > .I timespec > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -1053,7 +1053,7 @@ See also: > .TP > .I timeval > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -1086,7 +1086,7 @@ See also: > .TP > .I uid_t > .RS > -.PP > +.br > Include: > .IR ; > or > @@ -1120,7 +1120,7 @@ See also: > .TP > .I va_list > .RS > -.PP > +.br > Include: > .IR ; > or > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/