From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
libc-alpha@sourceware.org, bug-hurd@gnu.org,
Samuel Thibault <samuel.thibault@gnu.org>, Luca <luca@orpolo.org>
Subject: Re: [VERY RFC PATCH 2/2] hurd: Make it possible to call memcpy very early
Date: Fri, 21 Apr 2023 09:58:34 -0300 [thread overview]
Message-ID: <8408f776-6e4f-9f3b-cf75-80853d83bec7@linaro.org> (raw)
In-Reply-To: <CAN9u=HdZ15Lrzxs20MMCxA_YrBdm2UW=MWLk1WY2s_A87MH_fw@mail.gmail.com>
On 21/04/23 09:38, Sergey Bugaev wrote:
> On Fri, Apr 21, 2023 at 2:50 PM Adhemerval Zanella Netto
> <adhemerval.zanella@linaro.org> wrote:
>> It might work if you don't care about a different architecture than x86,
>> and that's why I added the alias (so each architecture is free to name
>> its ifunc variant). And the patch was exactly to handle the implicit
>> created mem* call from compiler, so I think you should take it in
>> consideration.
>
> Yes, sure, I wasn't really suggesting we do that change. My point is,
> I would like to make the same memcpy callsites both work during early
> startup and start calling the more efficient implementation once early
> startup is done -- if that's possible.
That's the whole idea of dl-symbol-redir-ifunc.h, since it is explicit
enable by TU.
>
>> And I trying to make reason why you need __mig_memcpy indirection for
>> MIG.
>
> See commit 56010b73e81e2cb1082e418699f98353598fe671 (as pointed out by
> Samuel yesterday), which references [0]. But that's only relevant for
> SHARED; for static we could avoid that redirection and call memcpy
> directly indeed.
>
> [0]: https://sourceware.org/pipermail/libc-alpha/2020-November/119575.html
This seems essentially the very issue dl-symbol-redir-ifunc.h aims to fix.
next prev parent reply other threads:[~2023-04-21 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 18:42 [PATCH 1/2] hurd: Don't migrate reply port into __init1_tcbhead Sergey Bugaev
2023-04-20 18:42 ` [VERY RFC PATCH 2/2] hurd: Make it possible to call memcpy very early Sergey Bugaev
2023-04-20 20:25 ` H.J. Lu
2023-04-20 20:38 ` Adhemerval Zanella Netto
2023-04-21 9:27 ` Sergey Bugaev
2023-04-21 11:50 ` Adhemerval Zanella Netto
2023-04-21 12:38 ` Sergey Bugaev
2023-04-21 12:58 ` Adhemerval Zanella Netto [this message]
2023-04-21 13:56 ` Sergey Bugaev
2023-04-21 14:28 ` Adhemerval Zanella Netto
2023-04-22 11:59 ` Samuel Thibault
2023-04-22 12:18 ` Sergey Bugaev
2023-04-22 16:20 ` Samuel Thibault
2023-04-22 17:04 ` Sergey Bugaev
2023-04-21 11:51 ` Sergey Bugaev
2023-04-21 1:02 ` [PATCH 1/2] hurd: Don't migrate reply port into __init1_tcbhead Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8408f776-6e4f-9f3b-cf75-80853d83bec7@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=luca@orpolo.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).