public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Ying Huang" <ying.huang@oss.cipunited.com>
To: <schwab@linux-m68k.org>, <libc-alpha@sourceware.org>
Cc: <yunqiang.su@oss.cipunited.com>
Subject: Re:[PATCH] MIPS: Sync elf.h from binutils
Date: Tue, 16 May 2023 11:35:08 +0800	[thread overview]
Message-ID: <841c375a-4b02-90c6-05d7-281ef29abe5e@oss.cipunited.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hi,

> >/@@ -2158,8 +2284,11 @@ enum />/Val_GNU_MIPS_ABI_FP_64 = 6, />//* Using -mips32r2 -mfp64 -mno-odd-spreg. */ />/Val_GNU_MIPS_ABI_FP_64A = 7, />/+ /* This is reserved for backward-compatibility with an earlier />/+ implementation of the MIPS NaN2008 functionality. */ />/+ Val_GNU_MIPS_ABI_FP_NAN2008 = 8, />//* Maximum allocated FP ABI value. */ />/- Val_GNU_MIPS_ABI_FP_MAX = 7 />/+ Val_GNU_MIPS_ABI_FP_MAX = 9 /
> Shouldn't that be 8?
>
> Also, does that need an update to sysdeps/mips/dl-machine-reject-phdr.h?
>
/Val_GNU_MIPS_ABI_FP_MAX/  should  be 8 and need update sysdeps/mips/dl-machine-reject-phdr.h.

I would submit PATCH v2.

Thanks,

Ying

                 reply	other threads:[~2023-05-16  3:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=841c375a-4b02-90c6-05d7-281ef29abe5e@oss.cipunited.com \
    --to=ying.huang@oss.cipunited.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=yunqiang.su@oss.cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).