From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>, Bruno Haible <bruno@clisp.org>
Subject: Re: [PATCH 2/3] i686: Do not raise exception traps on fesetexcept (BZ 30989)
Date: Mon, 23 Oct 2023 23:32:08 +0000 [thread overview]
Message-ID: <848ce891-148b-f310-c988-8d308d89f3f5@codesourcery.com> (raw)
In-Reply-To: <20231023213659.3236496-3-adhemerval.zanella@linaro.org>
On Mon, 23 Oct 2023, Adhemerval Zanella wrote:
> + if (temp.__control_word & temp.__status_word & excepts)
> + /* Setting the exception flags may trigger a trap (at the next
> + floating-point instruction, but that does not matter).
> + ISO C 23 ?? 7.6.4.5 does not allow it. */
> + return -1;
Don't you need to check (~temp.__control_word), as in patch 3, since the
bits in the control word are set for masked exceptions, clear for
trapping?
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-10-23 23:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 21:36 [PATCH 0/3] Fix fesetexcept/fesetexceptflag on powerpc and x86 Adhemerval Zanella
2023-10-23 21:36 ` [PATCH 1/3] powerpc: Do not raise exception traps for fesetexcept/fesetexceptflag (BZ 30988) Adhemerval Zanella
2023-10-23 23:50 ` Bruno Haible
2023-10-23 21:36 ` [PATCH 2/3] i686: Do not raise exception traps on fesetexcept (BZ 30989) Adhemerval Zanella
2023-10-23 23:32 ` Joseph Myers [this message]
2023-10-24 0:17 ` Bruno Haible
2023-10-24 11:12 ` Adhemerval Zanella Netto
2023-10-24 13:35 ` Bruno Haible
2023-10-23 21:36 ` [PATCH 3/3] x86: Do not raises floating-point exception traps on fesetexceptflag (BZ 30990) Adhemerval Zanella
2023-10-24 0:19 ` Bruno Haible
2023-10-24 11:13 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=848ce891-148b-f310-c988-8d308d89f3f5@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=bruno@clisp.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).