From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 0BF5A3858D33 for ; Thu, 19 Oct 2023 19:53:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BF5A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0BF5A3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697745238; cv=none; b=q35Om2nLR199O3GR/ZbGyffoeSxxK1L/TDLfDozvj0zqmsvPLAM/iAXJNn9fz/J6vxhyb4rJyodoQbsKJj9tRgu46pTm/aYgYU0kFsrQg3vdXA3pl/eyrWkbkVeIU6nsPq9yFIj9RUK5bMa5TfX+ZePW20S22lvbQb0eMVWkHF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697745238; c=relaxed/simple; bh=ebZA5M8SlHrBgBU/7wlYzov+VqG7F1UEsBTKZIfa7tk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=V87YVJ8XofeJFp7BAh+IhGiCLDlWogYbNdrt15q7ZVNgar7w0LFgQQBFM4kro2xUtJeAp8YrqlrZHHY76f/0Jrmt5RYhM7k7COpZUHCz60vmb+BO6DM0vhByGHYjrC3NqMIy6KHAxXnncsGhleHgaYvle9IhH/wheXj9N9S2SCk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6b201a93c9cso108325b3a.0 for ; Thu, 19 Oct 2023 12:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697745235; x=1698350035; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VgS/+3JDhjHojKnF27SNHVFCjfpYuuABa3CaAUSWHbE=; b=I0HObH88i7fFBKQbNc53tE78+1XqvNGOqy0u8+X1Vgd6G5O/FPll967CC8Jtv6cMh7 euL7slt/m5Bo0h80Mxxh+6NtdtJoV9+SHowBBhd51XHxpuT+0lKanhigFUE89CXbohcr 0Xui6dB1sbJatcWgUn/auARF7+5nIiMLcdVsNCQOqkjXZFiV4PzagP/ge4bmXoqZojSW vDHM/FaUPuEVmIuirssSy367GV02TLrLxPGU3u0U3nQFHshAQ7Zck/gGbol5TGTicKzx BhRyB06OS9dxBTr2oxP3d4AsBXHqT/z0N/N5ix6YjyL7zptJxLIGJUZLJu3gj9inZP2V 7Y8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697745235; x=1698350035; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VgS/+3JDhjHojKnF27SNHVFCjfpYuuABa3CaAUSWHbE=; b=HP4Mt9ZqdbekaQpxqUoe7khTCWkepFAOFgOCoV1Wk2O3oF8lOsvHlTLIXqgo2+bqzt mg98BTme8M8YNLJc/XwfuUKbAf+s2RhGe9Jvp0CaGO5h0FMqM1ol0Ady+uoL6IUjaPjN HfSz7YN2bUI+SahEeMBm0Akv7WbDxuye8tBte0MWZdWxN428ywxOnkAg8k3GcYhij1/n xwkKqI95Y41PtqoL49g51UX19IuhFkuG3y6wqMWmRWjDshYUF5lYyyoOlpaYDl8TWSan fCCVnqa5vFSLQStYPlugaCYQfymxQ3MgntzLC3s3CTIBiZmx9xK6OOvLMvNfM8YxOyrg ypOQ== X-Gm-Message-State: AOJu0YzwLePAZCWLnNucbG7tiLcHMEGopUaor171P4q2ag+UNk7Gx2vC Jx7d+FgAfsNLLgSAtHcmPiDxfw== X-Google-Smtp-Source: AGHT+IHTKVVvoJNfRFIWXDL752Y5tJKvaDOiOXS+MAIlkISagTecE7l93udvElnSxErg04uoCoHIIA== X-Received: by 2002:a05:6a20:3d11:b0:171:a8bc:74b2 with SMTP id y17-20020a056a203d1100b00171a8bc74b2mr3331685pzi.7.1697745234852; Thu, 19 Oct 2023 12:53:54 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:a647:51c8:7d15:99b:dc36? ([2804:1b3:a7c3:a647:51c8:7d15:99b:dc36]) by smtp.gmail.com with ESMTPSA id p9-20020a63e649000000b0057412d84d25sm142333pgj.4.2023.10.19.12.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 12:53:54 -0700 (PDT) Message-ID: <84a923c7-8a9e-4d1b-bc53-4841b1aed6ed@linaro.org> Date: Thu, 19 Oct 2023 16:53:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/16] Move 'hosts' routines from 'inet' into 'nss' Content-Language: en-US To: Arjun Shankar , libc-alpha@sourceware.org References: <20231002130150.1497733-1-arjun@redhat.com> <20231002130150.1497733-10-arjun@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20231002130150.1497733-10-arjun@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/10/23 09:55, Arjun Shankar wrote: > The gethostby* and gethostent* routines are entry points for nss > functionality. This commit moves them from the 'inet' subdirectory to > 'nss'. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > inet/Makefile | 17 ----------------- > inet/Versions | 4 +--- > nss/Makefile | 24 ++++++++++++++++++++++++ > nss/Versions | 2 ++ > {inet => nss}/gethstbyad.c | 0 > {inet => nss}/gethstbyad_r.c | 0 > {inet => nss}/gethstbynm.c | 0 > {inet => nss}/gethstbynm2.c | 0 > {inet => nss}/gethstbynm2_r.c | 0 > {inet => nss}/gethstbynm_r.c | 0 > {inet => nss}/gethstent.c | 0 > {inet => nss}/gethstent_r.c | 0 > {inet => nss}/tst-gethnm.c | 0 > 13 files changed, 27 insertions(+), 20 deletions(-) > rename {inet => nss}/gethstbyad.c (100%) > rename {inet => nss}/gethstbyad_r.c (100%) > rename {inet => nss}/gethstbynm.c (100%) > rename {inet => nss}/gethstbynm2.c (100%) > rename {inet => nss}/gethstbynm2_r.c (100%) > rename {inet => nss}/gethstbynm_r.c (100%) > rename {inet => nss}/gethstent.c (100%) > rename {inet => nss}/gethstent_r.c (100%) > rename {inet => nss}/tst-gethnm.c (100%) > > diff --git a/inet/Makefile b/inet/Makefile > index 4d053de748..d378542549 100644 > --- a/inet/Makefile > +++ b/inet/Makefile > @@ -46,14 +46,6 @@ routines := \ > ether_line \ > ether_ntoa \ > ether_ntoa_r \ > - gethstbyad \ > - gethstbyad_r \ > - gethstbynm \ > - gethstbynm2 \ > - gethstbynm2_r \ > - gethstbynm_r \ > - gethstent \ > - gethstent_r \ > getipv4sourcefilter \ > getnameinfo \ > getnetbyad \ > @@ -123,7 +115,6 @@ tests := \ > tst-checks-posix \ > tst-ether_aton \ > tst-ether_line \ > - tst-gethnm \ > tst-getni1 \ > tst-getni2 \ > tst-if_index-long \ > @@ -154,14 +145,6 @@ include ../gen-locales.mk > > ifeq ($(have-thread-library),yes) > > -CFLAGS-gethstbyad_r.c += -fexceptions > -CFLAGS-gethstbyad.c += -fexceptions > -CFLAGS-gethstbynm_r.c += -fexceptions > -CFLAGS-gethstbynm.c += -fexceptions > -CFLAGS-gethstbynm2_r.c += -fexceptions > -CFLAGS-gethstbynm2.c += -fexceptions > -CFLAGS-gethstent_r.c += -fexceptions > -CFLAGS-gethstent.c += -fexceptions > CFLAGS-rcmd.c += -fexceptions > CFLAGS-getnetbynm_r.c += -fexceptions > CFLAGS-getnetbynm.c += -fexceptions > diff --git a/inet/Versions b/inet/Versions > index a7c1a0fb6f..d937e9835c 100644 > --- a/inet/Versions > +++ b/inet/Versions > @@ -14,9 +14,7 @@ libc { > ether_ntoa_r; > > # g* > - getdomainname; gethostbyaddr; gethostbyaddr_r; gethostbyname; > - gethostbyname2; gethostbyname2_r; gethostbyname_r; gethostent; > - gethostent_r; getnetbyaddr; getnetbyaddr_r; getnetbyname; > + getdomainname; getnetbyaddr; getnetbyaddr_r; getnetbyname; > getnetbyname_r; getnetent; getnetent_r; getnetgrent; getnetgrent_r; > getprotobyname; getprotobyname_r; getprotobynumber; > getprotobynumber_r; getprotoent; getprotoent_r; > diff --git a/nss/Makefile b/nss/Makefile > index 148c6dc1cf..d0b564a033 100644 > --- a/nss/Makefile > +++ b/nss/Makefile > @@ -125,6 +125,29 @@ CFLAGS-getsgnam.c += -fexceptions > CFLAGS-getsgnam_r.c += -fexceptions > endif > > +# hosts routines: > +routines += \ > + gethstbyad \ > + gethstbyad_r \ > + gethstbynm \ > + gethstbynm2 \ > + gethstbynm2_r \ > + gethstbynm_r \ > + gethstent \ > + gethstent_r \ > + # routines > + > +ifeq ($(have-thread-library),yes) > +CFLAGS-gethstbyad.c += -fexceptions > +CFLAGS-gethstbyad_r.c += -fexceptions > +CFLAGS-gethstbynm.c += -fexceptions > +CFLAGS-gethstbynm_r.c += -fexceptions > +CFLAGS-gethstbynm2.c += -fexceptions > +CFLAGS-gethstbynm2_r.c += -fexceptions > +CFLAGS-gethstent.c += -fexceptions > +CFLAGS-gethstent_r.c += -fexceptions > +endif > + > # pwd routines: > routines += \ > fgetpwent \ > @@ -210,6 +233,7 @@ tests := \ > test-netdb \ > testgrp \ > tst-fgetsgent_r \ > + tst-gethnm \ > tst-getpw \ > tst-gshadow \ > tst-nss-getpwent \ > diff --git a/nss/Versions b/nss/Versions > index 99208cb9df..74ba4470d8 100644 > --- a/nss/Versions > +++ b/nss/Versions > @@ -21,6 +21,8 @@ libc { > getaliasbyname; getaliasbyname_r; getaliasent; getaliasent_r; > getgrent; getgrent_r; getgrgid; getgrgid_r; getgrnam; getgrnam_r; > getgroups; > + gethostbyaddr; gethostbyaddr_r; gethostbyname; gethostbyname2; > + gethostbyname2_r; gethostbyname_r; gethostent; gethostent_r; > getpw; getpwent; getpwent_r; getpwnam; getpwnam_r; getpwuid; getpwuid_r; > getspent; getspent_r; getspnam; getspnam_r; > > diff --git a/inet/gethstbyad.c b/nss/gethstbyad.c > similarity index 100% > rename from inet/gethstbyad.c > rename to nss/gethstbyad.c > diff --git a/inet/gethstbyad_r.c b/nss/gethstbyad_r.c > similarity index 100% > rename from inet/gethstbyad_r.c > rename to nss/gethstbyad_r.c > diff --git a/inet/gethstbynm.c b/nss/gethstbynm.c > similarity index 100% > rename from inet/gethstbynm.c > rename to nss/gethstbynm.c > diff --git a/inet/gethstbynm2.c b/nss/gethstbynm2.c > similarity index 100% > rename from inet/gethstbynm2.c > rename to nss/gethstbynm2.c > diff --git a/inet/gethstbynm2_r.c b/nss/gethstbynm2_r.c > similarity index 100% > rename from inet/gethstbynm2_r.c > rename to nss/gethstbynm2_r.c > diff --git a/inet/gethstbynm_r.c b/nss/gethstbynm_r.c > similarity index 100% > rename from inet/gethstbynm_r.c > rename to nss/gethstbynm_r.c > diff --git a/inet/gethstent.c b/nss/gethstent.c > similarity index 100% > rename from inet/gethstent.c > rename to nss/gethstent.c > diff --git a/inet/gethstent_r.c b/nss/gethstent_r.c > similarity index 100% > rename from inet/gethstent_r.c > rename to nss/gethstent_r.c > diff --git a/inet/tst-gethnm.c b/nss/tst-gethnm.c > similarity index 100% > rename from inet/tst-gethnm.c > rename to nss/tst-gethnm.c