public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>, DJ Delorie <dj@redhat.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] malloc: Use C11 atomics on memusage
Date: Mon, 3 Apr 2023 10:35:17 -0300	[thread overview]
Message-ID: <84fad946-c7b4-5c01-00d6-586331b901b9@linaro.org> (raw)
In-Reply-To: <PAWPR08MB89824B203A00831625FEA1F683929@PAWPR08MB8982.eurprd08.prod.outlook.com>



On 03/04/23 10:10, Wilco Dijkstra wrote:
> Hi,
> 
>> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>>> -#include <atomic.h>
> 
> Just double checking, does this mean we are now happy with bypassing
> the internal header, all its defines/checks and target implementations,
> and require that all supported targets have correctly implemented C11
> atomics?

I did it for memusage mainly because it is standalone library that in
theory can be move out glibc (and I might do it, similar to what I did
for libSegfault).

> 
> This would make my outstanding patches on cleaning up atomics a lot
> easier, however I'm wondering whether this will "just work" given the
> intermediate state will be a mix between C11 atomics and various target
> specific hacks. My patches tried hard to avoid such issues by taking
> tiny steps in improving this and keeping everything consistent.

I think for internal usage, we might still use the internal atomic.h. 
Maybe what we can do it to fist move all the internal code to the
C11-like interface and then check if we can move to compiler builtins.

      reply	other threads:[~2023-04-03 13:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 16:17 Adhemerval Zanella
2023-03-29 19:16 ` DJ Delorie
2023-04-03 13:10   ` Wilco Dijkstra
2023-04-03 13:35     ` Adhemerval Zanella Netto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84fad946-c7b4-5c01-00d6-586331b901b9@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).