From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id D29F63858D20 for ; Wed, 1 May 2024 14:20:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D29F63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D29F63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714573204; cv=none; b=c39+Fkop/EWmZ+IP4xiUAf7PQ5vz/X7e7H91I6EgSXB7hZyEBBC/gaPGMtMAVYl1WFXhXUDxdI1hW32XAPM8PRbGawLxssS6MxD7CUrTxHatl/poUMOG/mvUA4/L6tGOnr8/qfTIBpqxhNa19C2kRpDLZlyus+M88nV9JsHpTI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714573204; c=relaxed/simple; bh=rmpwYFhAkbH9yh4x+0/4Oyg2Jryu0Hf98war7jVoCCM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SzZSIqdE/Ov3jUSGJPpqhyV9S0iqK8LJlMrkttoafkZHWgzcQMp/O7rlrvZKoe5XkolKUOj0zCwo+czHaY6DUfQAJ17HuQ+knsKyDgm/OmxJOJX4nc8Vi156GmNvzibortFJZ88dUC0ljzOt68hweMCyMxE4aiwPdtA9GvXj624= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6ed2170d89fso560628b3a.1 for ; Wed, 01 May 2024 07:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714573201; x=1715178001; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=DHD8qW5FcMAi5IPVnfS74oFVxmfHChKXXoKOLXQr3+s=; b=e8/JkzjFTGdfWFhcUjZRDERD2I9H/IKKfQ8cJxsOiwqYuhKECLGkJltYELiYin3b4F jGbksae5Sm8X6y9ZvmCZe2uv7bs/CWfFGDUudWY9ewTjh7p7XAVEZ8IzmWd6bQxey2Y/ uJoElDJPWgIBWqQbtUlA3Cuqo1Wn9QL7GWTzn6aO0w/PfgSTfZHPaCad1Z5k/lTf0ELt W/HTF5exEzWEAmrv6Tdxq5nHrPC/LmomROtvft7yC9A6/J1Io8TdfEGwNCnFa37LSmiX Pv4wVKs6UN8rlj8/bzH/VwpXHMJ6ts9Y8I1cOvTWFMp2Ejd1JYvTrwbuSTLu6iYwgklF aCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714573201; x=1715178001; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DHD8qW5FcMAi5IPVnfS74oFVxmfHChKXXoKOLXQr3+s=; b=E7FL3YBJYNa3U/wHDpKAP5otk5U7mfEwMVQ2ZcTitiqmn5lahLaMCfBT3XngNz1FZ1 146dOeVckbdLpGxSPqb/sD9+IiHhr2UviEUjlfP40OzcHmgx1uwc4VRy2ZJwCUD4On3m 5zbZmu8uOXHEwqWWO/9x4Ogo7OphRpnMDhK+2ElpuhcHXU9BgRExlQIZITsZdDal66uG OFrvtNhcWCn/Ec6+zhMoTaRg0F5wmDA2sFbzYxutzlMDF8kPIa/+f6k1aLmwqQNf6NjG nwW2yEf5Bv5RTC6saYNFtGy8MHUPJXAW+afS9uJ0jOnEdLRUGtbA1MWfi/Ter58HqrkF HJug== X-Gm-Message-State: AOJu0YxANSO4nJ7YKo4NbBa46RMWnNDCod2Qb10JHX7JcBwk3vnBlRnu 4dE9HL7xdAmDw8wa20VGpcqTRCGRKC9XBeUKiqHrgdLM7eRcOvuesO5qFlaxF7OR7kEnbX98YEd n X-Google-Smtp-Source: AGHT+IEXV+wC2lxxsUPoxqU5fPzNb97ob2Cm9lkm8wwI+qaEzyXqeDfKTWP4AN1rjLfuQcrb9Cscng== X-Received: by 2002:a17:90a:348f:b0:2af:42ce:54f with SMTP id p15-20020a17090a348f00b002af42ce054fmr8570076pjb.6.1714573201626; Wed, 01 May 2024 07:20:01 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:e3c5:d5b:1509:7f55:16c2? ([2804:1b3:a7c1:e3c5:d5b:1509:7f55:16c2]) by smtp.gmail.com with ESMTPSA id s23-20020a63dc17000000b005f77433b4f9sm22677204pgg.81.2024.05.01.07.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 07:20:00 -0700 (PDT) Message-ID: <851ebdd8-a63a-4581-819f-e55069bbf1e0@linaro.org> Date: Wed, 1 May 2024 11:19:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] elf: Only process multiple tunable once (BZ 31686) To: Florian Weimer Cc: libc-alpha@sourceware.org, Joe Simmons-Talbott , Siddhesh Poyarekar , Yuto Maeda References: <20240430192739.1032549-1-adhemerval.zanella@linaro.org> <20240430192739.1032549-2-adhemerval.zanella@linaro.org> <871q6lpu8y.fsf@oldenburg.str.redhat.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <871q6lpu8y.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/05/24 09:54, Florian Weimer wrote: > * Adhemerval Zanella: > >> The parse_tunables_string is a tunable entry on the 'tunable_list' list >> to be set later without checking if the entry is already present. If >> leads to a stack overflow if the tunable is set multiple times, >> for instance: >> >> GLIBC_TUNABLES=glibc.malloc.check=2:... (repeat over the number of >> total support for different tunable). >> >> Instead, use the index of the tunable list to get the expected tunable >> entry. Since now the initial list is zero-initialized, the compiler >> might emit an extra memset and this requires some minor adjustment >> on some ports. >> >> Checked on x86_64-linux-gnu and aarch64-linux-gnu. >> >> Reported-by: Yuto Maeda > > Is this fixing a particular commit? If it does, could you mention that > in the commit message? Yes, I added on the cover-letter (680c597e9c3). I will add it on the comment message as well.