From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 32746388F056 for ; Tue, 16 Jun 2020 19:06:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 32746388F056 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05GJ1cHY163857 for ; Tue, 16 Jun 2020 15:06:36 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 31ptqkuyvj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Jun 2020 15:06:36 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05GIt6X4032042 for ; Tue, 16 Jun 2020 19:06:36 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma02dal.us.ibm.com with ESMTP id 31q2qv0svj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Jun 2020 19:06:35 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05GJ6YKN52756976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Jun 2020 19:06:34 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF0156E052; Tue, 16 Jun 2020 19:06:34 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 746206E059; Tue, 16 Jun 2020 19:06:34 +0000 (GMT) Received: from [9.163.90.82] (unknown [9.163.90.82]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 16 Jun 2020 19:06:34 +0000 (GMT) Subject: Re: [PATCHv4 1/2] powerpc64le: refactor e_sqrtf128.c To: "Paul A. Clarke" , "Paul E. Murphy" Cc: libc-alpha@sourceware.org References: <20200616013359.GC24739@oc3272150783.ibm.com> From: Paul E Murphy Message-ID: <854afe0a-dabd-2eb1-1554-c11e66f04004@linux.ibm.com> Date: Tue, 16 Jun 2020 14:06:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200616013359.GC24739@oc3272150783.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-16_11:2020-06-16, 2020-06-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 cotscore=-2147483648 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006160131 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 19:06:38 -0000 On 6/15/20 8:33 PM, Paul A. Clarke wrote: > On Mon, Jun 15, 2020 at 03:59:06PM -0500, Paul E. Murphy via Libc-alpha wrote: >> Combine both implementations into a single file to allow >> building twice with appropriate multiarch support when possible. >> Notably, gcc7x does not supporting inlining sqrtf128 via the usual >> __builtin_sqrtf128, it arrived in gcc8. > > Not sure you need that last sentence. > >> Likewise, this maintains the existing optimal behavior when >> building with a power9 or newer cpu. > > You may not need this sentence either. It's pretty clear in the code. I've removed both, and pushed. Thank you for your review.