From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C45903890426 for ; Sun, 2 May 2021 19:30:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C45903890426 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-h4_817ZBOc-KCCPi8-9DAQ-1; Sun, 02 May 2021 15:30:27 -0400 X-MC-Unique: h4_817ZBOc-KCCPi8-9DAQ-1 Received: by mail-qv1-f70.google.com with SMTP id a6-20020a0ce3460000b02901c4f39aa36aso3233309qvm.21 for ; Sun, 02 May 2021 12:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Z7PJdif5CShnBUE6p3h4jfXZqtGjHEzL5DAsd2VZoeo=; b=gKKOWnAWVmHgBt18H8jBYI79HqISKhVhTPk+IGUNrO47KL/Ew0yklB/KavjqE6fLl0 2vRmYT7LckRZUnpoBFzLM2+HaVfEtgjRVK8y4rf7Un94F2NrHoNLELlcMIowSplR/dNO X+tsuU6Qxa3wzwY6uMzDuUNf1iryOqvI6W3Bv+7urdNJYpTAggimDDTklg/98m3orTBM MbVQtsW+PDQDUp/fJTjHPH9S0XXQ7FHmFRAgUQbkBZL3jPINcm0TO/3Zco6SVcCe5gLV ni2oSTOBfPZZbXf0yfBR3gHGmpTnKXm5/m/CF4yB6Vft5Pt52gjCbxwIOZSmK7ZtuZAA u6QQ== X-Gm-Message-State: AOAM532ddM0MAzlCADLbXtgq4397ZKV6rInkWGsdOzPt3R088Y7vOXLp vvUIddaGjK4ZORIsHVhf42AumiEU2TwzHYhyc6GUMTef3rt34maqB+oq1gluEhT7q3rN8gH5g4h QdkRQaRPgGG/GMPxHznMKRT//dGRsYMEDLWgtitQEA22XMTHfh5yRKxe/IsC3xP2OMTpbNA== X-Received: by 2002:a37:de16:: with SMTP id h22mr15873464qkj.351.1619983826363; Sun, 02 May 2021 12:30:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKjj6pPHfG6kfPpjGuy8C8nu44G81koYyZygd+8igUyuFzhi95pOize6IfpTcAfwYKtRLMAw== X-Received: by 2002:a37:de16:: with SMTP id h22mr15873452qkj.351.1619983826136; Sun, 02 May 2021 12:30:26 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id 69sm6702439qkk.58.2021.05.02.12.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 May 2021 12:30:25 -0700 (PDT) Subject: Re: [PATCH 00/14] nptl: Move remaining rwlock functions into libc To: Florian Weimer , libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: <855ed514-d9af-da6e-8076-2f0ea16a41d9@redhat.com> Date: Sun, 2 May 2021 15:30:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 May 2021 19:30:30 -0000 On 4/23/21 1:36 PM, Florian Weimer via Libc-alpha wrote: > The clock*lock are a bit more complex, and I followed what I did in the > mutex and condition variable cases. I also removed some unsued > functionality. > > Tested on i686-linux-gnu and x86_64-linux-gnu. Built with > build-many-glibcs.py. Overall tested and reviewed on x86_64 and i686. LGTM. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > Thanks, > Florian > > Florian Weimer (14): > nptl: Move pthread_rwlock_clockrdlock into libc > nptl: Move pthread_rwlock_clockwrlock into libc > nptl: Move pthread_rwlock_destroy into libc > nptl: Move pthread_rwlock_init into libc > nptl: Move pthread_rwlock_timedrdlock into libc > nptl: Move pthread_rwlock_timedwrlock into libc > nptl: Move pthread_rwlock_tryrdlock into libc > nptl: Move pthread_rwlock_trywrlock into libc > nptl: Move pthread_rwlockattr_destroy into libc > nptl: Move pthread_rwlockattr_getkind_np into libc > nptl: Move pthread_rwlockattr_getpshared into libc > nptl: Move pthread_rwlockattr_init into libc > nptl: Move pthread_rwlockattr_setkind_np into libc > nptl: Move pthread_rwlockattr_setpshared into libc > > nptl/Makefile | 28 +++++------ > nptl/Versions | 49 ++++++++++++------- > nptl/pthreadP.h | 8 +-- > nptl/pthread_rwlock_clockrdlock.c | 23 ++++++--- > nptl/pthread_rwlock_clockwrlock.c | 23 ++++++--- > nptl/pthread_rwlock_destroy.c | 16 ++++-- > nptl/pthread_rwlock_init.c | 20 ++++++-- > nptl/pthread_rwlock_timedrdlock.c | 23 ++++++--- > nptl/pthread_rwlock_timedwrlock.c | 23 ++++++--- > nptl/pthread_rwlock_tryrdlock.c | 15 +++++- > nptl/pthread_rwlock_trywrlock.c | 15 +++++- > nptl/pthread_rwlockattr_destroy.c | 11 ++++- > nptl/pthread_rwlockattr_getkind_np.c | 11 ++++- > nptl/pthread_rwlockattr_getpshared.c | 12 ++++- > nptl/pthread_rwlockattr_init.c | 11 ++++- > nptl/pthread_rwlockattr_setkind_np.c | 11 ++++- > nptl/pthread_rwlockattr_setpshared.c | 11 ++++- > sysdeps/nptl/libc-lockP.h | 30 ++---------- > sysdeps/unix/sysv/linux/aarch64/libc.abilist | 32 ++++++++++++ > .../sysv/linux/aarch64/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/alpha/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/alpha/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/arc/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/arc/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/arm/be/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/arm/be/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/arm/le/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/arm/le/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/csky/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/csky/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/hppa/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/hppa/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/i386/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/i386/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/ia64/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/ia64/libpthread.abilist | 18 ------- > .../sysv/linux/m68k/coldfire/libc.abilist | 32 ++++++++++++ > .../linux/m68k/coldfire/libpthread.abilist | 18 ------- > .../unix/sysv/linux/m68k/m680x0/libc.abilist | 32 ++++++++++++ > .../sysv/linux/m68k/m680x0/libpthread.abilist | 18 ------- > .../sysv/linux/microblaze/be/libc.abilist | 32 ++++++++++++ > .../linux/microblaze/be/libpthread.abilist | 18 ------- > .../sysv/linux/microblaze/le/libc.abilist | 32 ++++++++++++ > .../linux/microblaze/le/libpthread.abilist | 18 ------- > .../sysv/linux/mips/mips32/fpu/libc.abilist | 32 ++++++++++++ > .../sysv/linux/mips/mips32/libpthread.abilist | 18 ------- > .../sysv/linux/mips/mips32/nofpu/libc.abilist | 32 ++++++++++++ > .../sysv/linux/mips/mips64/libpthread.abilist | 18 ------- > .../sysv/linux/mips/mips64/n32/libc.abilist | 32 ++++++++++++ > .../sysv/linux/mips/mips64/n64/libc.abilist | 32 ++++++++++++ > sysdeps/unix/sysv/linux/nios2/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/nios2/libpthread.abilist | 18 ------- > .../linux/powerpc/powerpc32/fpu/libc.abilist | 32 ++++++++++++ > .../powerpc/powerpc32/libpthread.abilist | 18 ------- > .../powerpc/powerpc32/nofpu/libc.abilist | 32 ++++++++++++ > .../linux/powerpc/powerpc64/be/libc.abilist | 32 ++++++++++++ > .../powerpc/powerpc64/be/libpthread.abilist | 18 ------- > .../linux/powerpc/powerpc64/le/libc.abilist | 32 ++++++++++++ > .../powerpc/powerpc64/le/libpthread.abilist | 18 ------- > .../unix/sysv/linux/riscv/rv32/libc.abilist | 32 ++++++++++++ > .../sysv/linux/riscv/rv32/libpthread.abilist | 18 ------- > .../unix/sysv/linux/riscv/rv64/libc.abilist | 32 ++++++++++++ > .../sysv/linux/riscv/rv64/libpthread.abilist | 18 ------- > .../unix/sysv/linux/s390/s390-32/libc.abilist | 32 ++++++++++++ > .../linux/s390/s390-32/libpthread.abilist | 18 ------- > .../unix/sysv/linux/s390/s390-64/libc.abilist | 32 ++++++++++++ > .../linux/s390/s390-64/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/sh/be/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/sh/be/libpthread.abilist | 18 ------- > sysdeps/unix/sysv/linux/sh/le/libc.abilist | 32 ++++++++++++ > .../unix/sysv/linux/sh/le/libpthread.abilist | 18 ------- > .../sysv/linux/sparc/sparc32/libc.abilist | 32 ++++++++++++ > .../linux/sparc/sparc32/libpthread.abilist | 18 ------- > .../sysv/linux/sparc/sparc64/libc.abilist | 32 ++++++++++++ > .../linux/sparc/sparc64/libpthread.abilist | 18 ------- > .../unix/sysv/linux/x86_64/64/libc.abilist | 32 ++++++++++++ > .../sysv/linux/x86_64/64/libpthread.abilist | 18 ------- > .../unix/sysv/linux/x86_64/x32/libc.abilist | 32 ++++++++++++ > .../sysv/linux/x86_64/x32/libpthread.abilist | 18 ------- > 79 files changed, 1251 insertions(+), 635 deletions(-) > -- Cheers, Carlos.