* [PATCH][powerpc] Fix tiny bug in strncmp.c
@ 2019-01-15 18:43 Paul Clarke
2019-01-15 19:21 ` Adhemerval Zanella
2019-01-16 16:06 ` Tulio Magno Quites Machado Filho
0 siblings, 2 replies; 3+ messages in thread
From: Paul Clarke @ 2019-01-15 18:43 UTC (permalink / raw)
To: GNU C Library, Tulio Magno Quites Machado Filho
A single underscore was omitted in
sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of
power8 version of strncmp instead of power9 version, with significant
performance degradation.
2019-01-15 Paul A. Clarke <pc@us.ibm.com>
* sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef.
diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
index ab7379d..d2791ce 100644
--- a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
+++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
@@ -37,7 +37,7 @@ extern __typeof (strncmp) __strncmp_power9 attribute_hidden;
/* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
ifunc symbol properly. */
libc_ifunc_redirected (__redirect_strncmp, strncmp,
-# ifdef __LITTLE_ENDIAN_
+# ifdef __LITTLE_ENDIAN__
(hwcap2 & PPC_FEATURE2_ARCH_3_00)
? __strncmp_power9 :
# endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][powerpc] Fix tiny bug in strncmp.c
2019-01-15 18:43 [PATCH][powerpc] Fix tiny bug in strncmp.c Paul Clarke
@ 2019-01-15 19:21 ` Adhemerval Zanella
2019-01-16 16:06 ` Tulio Magno Quites Machado Filho
1 sibling, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2019-01-15 19:21 UTC (permalink / raw)
To: libc-alpha
On 15/01/2019 16:42, Paul Clarke wrote:
> A single underscore was omitted in
> sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of
> power8 version of strncmp instead of power9 version, with significant
> performance degradation.
>
> 2019-01-15 Paul A. Clarke <pc@us.ibm.com>
>
> * sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef.
>
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
> index ab7379d..d2791ce 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
> @@ -37,7 +37,7 @@ extern __typeof (strncmp) __strncmp_power9 attribute_hidden;
> /* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
> ifunc symbol properly. */
> libc_ifunc_redirected (__redirect_strncmp, strncmp,
> -# ifdef __LITTLE_ENDIAN_
> +# ifdef __LITTLE_ENDIAN__
> (hwcap2 & PPC_FEATURE2_ARCH_3_00)
> ? __strncmp_power9 :
> # endif
>
LGTM, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][powerpc] Fix tiny bug in strncmp.c
2019-01-15 18:43 [PATCH][powerpc] Fix tiny bug in strncmp.c Paul Clarke
2019-01-15 19:21 ` Adhemerval Zanella
@ 2019-01-16 16:06 ` Tulio Magno Quites Machado Filho
1 sibling, 0 replies; 3+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2019-01-16 16:06 UTC (permalink / raw)
To: Paul Clarke, GNU C Library
Paul Clarke <pc@us.ibm.com> writes:
> A single underscore was omitted in
> sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of
> power8 version of strncmp instead of power9 version, with significant
> performance degradation.
>
> 2019-01-15 Paul A. Clarke <pc@us.ibm.com>
>
> * sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef.
LGTM too.
Pushed as 008b598e2a495024f9777006716cfd8668f3db33.
Thanks!
--
Tulio Magno
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-16 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 18:43 [PATCH][powerpc] Fix tiny bug in strncmp.c Paul Clarke
2019-01-15 19:21 ` Adhemerval Zanella
2019-01-16 16:06 ` Tulio Magno Quites Machado Filho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).