From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-99283-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 127289 invoked by alias); 15 Jan 2019 19:21:32 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 127220 invoked by uid 89); 15 Jan 2019 19:21:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qt1-f172.google.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=subject:to:references:from:openpgp:autocrypt:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=w1uUVeeXtz/1UM3shsz3p6volqQyXM7/CVyTaLfXWtA=;
        b=GwXb7tce9P4434QEHRncJW20PxDlUsRGE4ACZJH2R112EcL1rJ5bjPwxYFsoYxW/Af
         cnEapl55xOItOps+aEXRqTMJRP85tK7c8jzZwiRTIsoX0sYKcx+1EHiCd7YGQWBj1Eg7
         iGXPwWY1DOl82HlTPMIROSOUB5hgp07ax0J34=
Return-Path: <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH][powerpc] Fix tiny bug in strncmp.c
To: libc-alpha@sourceware.org
References: <ad7190f2-a310-ae7e-8be3-7b460d9b372c@us.ibm.com>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Openpgp: preference=signencrypt
Message-ID: <859978f8-e452-34f5-ca1b-a353a5b8c950@linaro.org>
Date: Tue, 15 Jan 2019 19:21:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <ad7190f2-a310-ae7e-8be3-7b460d9b372c@us.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-01/txt/msg00353.txt.bz2



On 15/01/2019 16:42, Paul Clarke wrote:
> A single underscore was omitted in
> sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of
> power8 version of strncmp instead of power9 version, with significant
> performance degradation.
> 
> 2019-01-15  Paul A. Clarke  <pc@us.ibm.com>
> 
> 	* sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef.
> 
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
> index ab7379d..d2791ce 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
> @@ -37,7 +37,7 @@ extern __typeof (strncmp) __strncmp_power9 attribute_hidden;
>  /* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
>     ifunc symbol properly.  */
>  libc_ifunc_redirected (__redirect_strncmp, strncmp,
> -# ifdef __LITTLE_ENDIAN_
> +# ifdef __LITTLE_ENDIAN__
>  			(hwcap2 & PPC_FEATURE2_ARCH_3_00)
>  			? __strncmp_power9 :
>  # endif
> 

LGTM, thanks.