From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 7C5533858409 for ; Fri, 21 Jul 2023 14:04:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C5533858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3a3c77e0154so1374952b6e.1 for ; Fri, 21 Jul 2023 07:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689948248; x=1690553048; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MVpg+7nmqjQ6nChZv/+1SFYlXa3berWHpGjmLDw9qUU=; b=IFYeIFyUfYRKTiAS1y5/Mhlnw1FABrrQo3wggugOi5aWO1E4hOEOLjcfdCEwAUjM8/ 5cAWYCFipMuIXb7GzpNSEAS2ABowgLDdKZ6Lds0OouEDLVWwHXWQVDOa3FQidhq6nbVY Bf9YdsNse4aV7CHsp7mK40qygUkggbd/pbEX372Jq+mmgBTlbBXpHiWuqgKNwnfP5dlg 9atsMXIjk2Xaa8/RMjeGN1OevqKmaRJfUapSirLSLwXaft0YdKoNnEZYwTWD16aCZjNX ORcEPN3FPFfvyyOnC1PE2T0VMaHhC18+FzTNHPGSSfEKDOW03z476tWWV2kWV3uQTVSv AKTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689948248; x=1690553048; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MVpg+7nmqjQ6nChZv/+1SFYlXa3berWHpGjmLDw9qUU=; b=mFfTI+A7TglDRvuA1ysybOn2JhcfT716oF4xslfwv1jjXvep9uZHezcnnZUGxbD4LY Fjxt+RNRBvEcnA/IJjXptkUc2j/2A2rp9+34Z8xbDN0vgAxhaVMZs0JBbUnGGJbpv4MI cj7JFQFcFpxN8h/IeDJaQZpAuZv3bdAkapHmNRIG0jL9E4u0FEgmgtCuhEmE58I/YHz9 ugdr5/Y7lVdHQEZnmE47V1VNW7563iPfOIW3ZpabNHXQMXeetYE29NIIZPNMxRmWoHzr GlBklxkIz9nEq0hPyYvEUPTfA7BpvhhoBe2rlwfgkrpTpr3DFYDVQKZPmnlLicmT33Tq /M8g== X-Gm-Message-State: ABy/qLbUWeBF6GkVv90qqtBl7GlNxZax+MeGI5ITN1A4PLVtsFCZMlRE PY8E2ksAqIlt1KqDWH0uhsCiZOFMMWaPOAXimB6eDg== X-Google-Smtp-Source: APBJJlFoEbC18Cat083j85xV0PrQEoSRLKrXRNqccVo6KLBUUDPlE5aeDNpg56koeW160OwojPVZVg== X-Received: by 2002:a05:6808:1415:b0:398:2c02:20a2 with SMTP id w21-20020a056808141500b003982c0220a2mr2889225oiv.17.1689948248679; Fri, 21 Jul 2023 07:04:08 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:d4d2:a1c5:8e8b:25fe:79f3? ([2804:1b3:a7c0:d4d2:a1c5:8e8b:25fe:79f3]) by smtp.gmail.com with ESMTPSA id s15-20020a056808208f00b003a1f1933957sm1429451oiw.16.2023.07.21.07.04.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 07:04:08 -0700 (PDT) Message-ID: <859ffd6b-7a35-ff9b-f833-78a35456766a@linaro.org> Date: Fri, 21 Jul 2023 11:04:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] localedata: Translit common emojis to smileys [BZ #30649] Content-Language: en-US To: Colin Leroy-Mira , libc-alpha@sourceware.org References: <20230721065203.3268784-1-colin@colino.net> <00a98f21d5db91e9e67f4b0b5a59f7cc9fd82feb@colino.net> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <00a98f21d5db91e9e67f4b0b5a59f7cc9fd82feb@colino.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/07/23 10:25, Colin Leroy-Mira via Libc-alpha wrote: > Hello, > > And sorry for spamming - I've seen that v2 of the patch does not pop in the Patchwork list at https://patchwork.sourceware.org/project/glibc/list/ and thought my patch tag in the subject was wrong, but that's apparently not that. > > Could the raw UTF-8 in localedata/tst-iconv-emojis-trans.c be the problem? > > Should I remove that commented declaration? I added it because a similar one is included in localedata/tst-iconv-math-trans.c. I am not sure, but it could this indeed. In any case I would recommend you to remove the comments, it is not clear the would be correctly displayed in all environments and it can confusing. Could you resend another version without the comment?