From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 225B33839076 for ; Tue, 30 Aug 2022 14:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 225B33839076 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-11f4e634072so2798996fac.13 for ; Tue, 30 Aug 2022 07:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=G2h7zzjr0gvAClkNL4/b8uA34wMnOqorhzxoO0UEk4E=; b=i58kesD5w87oo4uOVcK5kUZtFubD5ZVoL7igEoduzfpOWO42worxT/i0RRJIg77ZIT oZjXDSBzASH9xw4uRFVfLko2lp5OIZEf2Raa5IpKU40JbfIxV+9WndlcOYEAm0VwG2gE J7v2aXG4U8CLuRGzVXqGyPi3KzGbXuH28qICCXhy/Uvzgs+/fk7/iXmE9CZzRVW4mk2q cqH6UcbT7a+eiIFzyql/p30sssofHA+3MIHx8E7iAbFx5mDgPgZOARlbGbmTxwjs4xX/ kqS4xcmb32MiQj0ZgoBlnAHiXNs6MQMU/0ugarg6Po6fDTKGl2CBlnLw13JrhpHcIyHi q9qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=G2h7zzjr0gvAClkNL4/b8uA34wMnOqorhzxoO0UEk4E=; b=ILRJ7dn23ndT7xLrCtYSGPtZJZswlD58b7KtKKSbUaRsP8LsGYbDG46WKIfSmxHvv2 Qgf4zq4k75GGJVAPt+5Dt6DYUzpL7E/0N0vRg8QPY1iL99aWuPO3cF4RySxuwT+5wuK4 AcginCX7mhaOyIA3Urw0RZJKteHH2O8O9acwDveSOb1Y1yZ0IO/zH0Kci7MsAS5xWUat f2qxcNPHCyMkCNbhQyAxC+82KWdnNUm2w2k0bUKYIWX68v/h/xnyAcmjNcTI+bWJYrTm RBBYfLyk1Bt7dTfh3Tt+++nazRxssk7ncOmQuts+LnlR1ahGuw443aOdsjunBk5PjzXx NRZw== X-Gm-Message-State: ACgBeo3AQEMHPJlYIFbIceiqohhNtdShoDDDIhNIMVrKUe3Ro/mDDVzM s26csc5vKLrJrbDTWstViHxGjFKV0f38zw== X-Google-Smtp-Source: AA6agR6iPhm0AYjonq/3skFgQK/IJTNVBaMlal38miygOWYMwNADNfo7P/PB+hGjd4XxcLHX93ShHg== X-Received: by 2002:a05:6870:3914:b0:11c:7f09:96fa with SMTP id b20-20020a056870391400b0011c7f0996famr9946081oap.50.1661869407760; Tue, 30 Aug 2022 07:23:27 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:745e:449b:a205:b33e:4a53? ([2804:1b3:a7c0:745e:449b:a205:b33e:4a53]) by smtp.gmail.com with ESMTPSA id i16-20020a056870a69000b0010d910ffc3asm7905540oam.18.2022.08.30.07.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 07:23:27 -0700 (PDT) Message-ID: <85a010fe-e2a8-56bb-68d0-fec449cec164@linaro.org> Date: Tue, 30 Aug 2022 11:23:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] m68: Enforce 4-byte alignment on internal locks (BZ #29537) Content-Language: en-US To: Carlos O'Donell , libc-alpha@sourceware.org, glaubitz@physik.fu-berlin.de References: <20220830133504.2669323-1-adhemerval.zanella@linaro.org> <933ac04b-5d33-c482-67a6-ce176f3170a7@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <933ac04b-5d33-c482-67a6-ce176f3170a7@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/08/22 11:18, Carlos O'Donell wrote: > On 8/30/22 09:35, Adhemerval Zanella via Libc-alpha wrote: >> The HPPA also requires a 16-byte alignment for locks, although it is >> just a historical artifact to keep compatibility with old >> implementation. >> --- >> sysdeps/nptl/libc-lockP.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h >> index d3a6837fd2..9efe962588 100644 >> --- a/sysdeps/nptl/libc-lockP.h >> +++ b/sysdeps/nptl/libc-lockP.h >> @@ -34,7 +34,7 @@ >> #include >> >> /* Mutex type. */ >> -typedef int __libc_lock_t; >> +typedef int __libc_lock_t __LOCK_ALIGNMENT; >> typedef struct { pthread_mutex_t mutex; } __rtld_lock_recursive_t; >> typedef pthread_rwlock_t __libc_rwlock_t; > > Are you able to verify that this doesn't change the ABI of any other > structures that might have an internal lock? > > Normally I would use libabigail[1] before and after the patch to look > for subtype size changes in public ABIs/APIs. > It should not and I would consider this an bug since the header is internal only and all definitions are used solely on internal code (although pthreadtypes-arch.h is an installed header, libc-lockP.h is not).