From: Stefan Liebler <stli@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Cc: "Carlos O'Donell" <carlos@redhat.com>,
ldv@altlinux.org, Siddhesh Poyarekar <siddhesh@redhat.com>
Subject: Re: [PATCH] S390: Sync ptrace.h with kernel. [BZ #21539]
Date: Thu, 20 Jul 2017 07:38:00 -0000 [thread overview]
Message-ID: <85a36444-ca8b-5621-11f3-25c4083f0f92@linux.vnet.ibm.com> (raw)
In-Reply-To: <cb82d595-b007-46f8-d816-cc018e4f5c05@redhat.com>
On 07/18/2017 04:11 PM, Carlos O'Donell wrote:
> On 07/18/2017 09:39 AM, Dmitry V. Levin wrote:
>> On Tue, Jul 18, 2017 at 09:31:49AM -0400, Carlos O'Donell wrote:
>>> On 07/18/2017 06:20 AM, Dmitry V. Levin wrote:
>>>> Mark Wielaard has spotted [1] a regression that I missed during review.
>>>> After this change, this test case fails to compile with the following
>>>> diagnostics:
>>>>
>>>> $ gcc -c -xc -o/dev/null - <<'EOF'
>>>> #include <asm/ptrace.h>
>>>> #include <sys/ptrace.h>
>>>> EOF
>>>
>>> This is a linux/glibc header coordination issue.
>>
>> Not really, this is a new issue since glibc-2.25.
>
> It is both a new issue and a header coordination issue, the two are not
> mutually exclusive.
>
>>> https://sourceware.org/glibc/wiki/Synchronizing_Headers
>>
>> This project doesn't appear to be alive, unfortunately.
>
> The project is alive. We are the project. We need to send patches upstream
> to the Linux kernel to keep fixing inclusion ordering issues where we need
> them fixed.
>
> When 2.27 opens I have a pile of header inclusion ordering fixes I want to
> propose along with tests for them, but I haven't had a chance to submit. So
> we can discuss this in a few weeks.
>
>>>> The following change fixes this and similar compilation issues that arise
>>>> when sys/ptrace.h is included after linux/ptrace.h:
>>>
>>> This is a known conflict, and needs to be fixed properly using libc-compat.h
>>> on the kernel side and the appropriate defines on the glibc side.
>>
>> No, there was no conflict between asm/ptrace.h and sys/ptrace.h on s390
>> in glibc-2.25, and we should avoid introducing new conflicts.
>
> I have not verified that inclusion worked on both orders, if it did, then
> this is indeed a regression.
Before my commit "S390: Sync ptrace.h with kernel. [BZ #21539]",
both orders compiled without a failure:
#include <asm/ptrace.h>
#include <sys/ptrace.h>
=> okay (but fails after my commit)
#include <sys/ptrace.h>
#include <asm/ptrace.h>
=> okay
However if somebody used linux/ptrace.h instead of asm/ptrace.h:
#include <linux/ptrace.h>
#include <sys/ptrace.h>
=> fail
#include <sys/ptrace.h>
#include <linux/ptrace.h>
=> okay
With Dimitry's patch, all four cases are okay.
>
> However, I would like to take a step back:
>
> * Why is this issue a blocker? What software does it stop from building?
>
> * Can we delay the fix until after the release and fix it properly?
>
> Mark, Is this a problem for Valgrind?
>
Carlos, shall we commit Dimitry's patch before the release?
Then we don't have this regression compared to glibc 2.25 release.
Bye.
Stefan
next prev parent reply other threads:[~2017-07-20 7:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 10:17 Stefan Liebler
2017-06-06 10:44 ` Andreas Schwab
2017-06-06 10:58 ` Dmitry V. Levin
2017-06-06 11:56 ` Stefan Liebler
2017-06-08 12:02 ` Stefan Liebler
2017-06-13 20:05 ` Dmitry V. Levin
2017-06-19 13:11 ` Stefan Liebler
2017-06-19 13:26 ` Dmitry V. Levin
2017-06-19 14:34 ` Stefan Liebler
2017-06-30 10:09 ` Florian Weimer
2017-07-04 8:22 ` Stefan Liebler
2017-07-04 9:41 ` Florian Weimer
2017-07-04 15:37 ` Stefan Liebler
2017-07-07 10:22 ` Stefan Liebler
2017-07-07 10:45 ` Florian Weimer
2017-07-07 13:54 ` Stefan Liebler
2017-07-11 8:39 ` Stefan Liebler
2017-07-18 10:20 ` Dmitry V. Levin
2017-07-18 13:31 ` Carlos O'Donell
2017-07-18 13:39 ` Dmitry V. Levin
2017-07-18 14:11 ` Carlos O'Donell
2017-07-18 14:28 ` Mark Wielaard
2017-07-18 14:40 ` Mark Wielaard
2017-07-20 7:38 ` Stefan Liebler [this message]
2017-07-20 8:07 ` Carlos O'Donell
2017-07-20 8:32 ` Stefan Liebler
2017-07-24 3:51 ` Dmitry V. Levin
2017-07-24 7:18 ` Stefan Liebler
2017-07-18 13:41 ` Stefan Liebler
2017-07-18 14:12 ` Carlos O'Donell
2017-07-18 14:16 ` Dmitry V. Levin
2017-07-19 8:40 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85a36444-ca8b-5621-11f3-25c4083f0f92@linux.vnet.ibm.com \
--to=stli@linux.vnet.ibm.com \
--cc=carlos@redhat.com \
--cc=ldv@altlinux.org \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).