From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18721 invoked by alias); 19 Apr 2017 21:02:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 18698 invoked by uid 89); 19 Apr 2017 21:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f171.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=EVIW/QA4k586ZQRMlYWVmcFA4+vfE5FYLq5w3lxPHWs=; b=kiScvGzGtbsLVGx8JYThbVUybSLd6ttrKtyIHxMp6q9CvlLXc1o0Qwz6nb78WiuzDC dcJ4zHe02TNHT/mkP79Z+ISp99ni46S34e8wGa2/4JCP2b4hU7Ho96wpJQuxpwxHFWfb 3Z20dcBfRyDknArN1XXgscJo7ehKY82jRAnvRqf3HcF185YhPEU/oCzNLX4dFYXBWV/6 GevMUzEq/cVbNaV8zhCyb8BlN0HnqG/tgMgv6NpwaK5Z4UBw9mZ6KdyjSmpBEP2vHe0O EHJFsQ+XBe6rVDbbrAhSTfposPMGSYpAuxZQE0AIIIyJolBC5OPP5DeAEc8yERlI5oky C+vg== X-Gm-Message-State: AN3rC/61qRY6x86ZosjFWNJbIWiQjJArU8+DWb0s8cvtoV5m+L/idFsf /VUai+goI0TkZiVTIvwVQg== X-Received: by 10.200.36.212 with SMTP id t20mr5088046qtt.269.1492635735545; Wed, 19 Apr 2017 14:02:15 -0700 (PDT) Subject: Re: [PATCH 1/2] nptl: Remove __ASSUME_SET_ROBUST_LIST To: Florian Weimer References: <1492550000-31374-1-git-send-email-adhemerval.zanella@linaro.org> <35b8a72e-dfce-6cd1-0998-a3866239da30@redhat.com> <85636314-6928-361f-234b-badec623b5a5@linaro.org> Cc: GNU C Library From: Adhemerval Zanella Message-ID: <85d36884-2c64-c585-f07b-f302ab8c7aaf@linaro.org> Date: Wed, 19 Apr 2017 21:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-04/txt/msg00398.txt.bz2 On 19/04/2017 15:09, Florian Weimer wrote: > On 04/19/2017 07:38 PM, Adhemerval Zanella wrote: >> On Wed, Apr 19, 2017 at 12:28 PM, Florian Weimer wrote: >>> On 04/19/2017 04:17 PM, Adhemerval Zanella wrote: >>>> >>>> The problem is kernel supports for some architecture depends of kernel >>>> config >>>> and the underlying hardware revision/model. >>> >>> >>> I understand that. But I have seen a lot of use of robust mutexes lately, >>> and I'm sure these developers aren't aware that the mutexes aren't portable >>> across GNU/Linux (the Linux architecture subset supported by glibc). >>> >>> I expect it's like the missing accept4 system call—you need to provide the >>> set_robust_list system call in the kernel if you want to a working, modern >>> system. >> >> But my point is with current minimum supported kernel version for some >> architectures >> we can't simple assume set_robust_list support and even bumping minimum kernel >> version for some architectures also do not solve the issue (on mips >> for instance). > > Hmm, maybe you are right, and we have to keep things this way for now. > > But I don't like that your patch reintroduces the conditional code. You could use > > #define __set_robust_list_avail 1 > > for the __ASSUME_SET_ROBUST_LIST case to reduce clutter, and let GCC do the rest. > > Thanks, > Florian Alright, I will change it and send a new version.