From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id 03A9F3858406 for ; Wed, 21 Sep 2022 13:57:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03A9F3858406 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x234.google.com with SMTP id n83so8081363oif.11 for ; Wed, 21 Sep 2022 06:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=V2u2U/d/VRLuTvfkv8sTfy1z/Vsb+cNWhiooHfosYR4=; b=DniXY6mLS+Bc27PesUtWyaSINY8ccyWpNkeqisiH5gdqTnvWxp9UK5Cf1U+P0z7IeG fNCE4W20B2SgAIodgTMmtQpZNFOgk5V87P8M8UwrrADrw/14gqlkJMawhC6upO3DfDrQ +/xLqbr+9b+MllkAMCooP1zyUvfdcRxRy+fN6mgho/rrOmBpbbRXjbnQX9QWPtHgD71U 1mr8Z8z4dbi/522UNPyO0rYTcG1BYBNKP54AXRZpfaLtQ2Ao5oN6AYp5j38W6F6s0xxF hesODQ5lw6akqmgcwO2c5XfWlkaL7ZJqOkkxaTaDGqF5jNfO6+OSHQ3FsgriTF+WZAZy qi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=V2u2U/d/VRLuTvfkv8sTfy1z/Vsb+cNWhiooHfosYR4=; b=r4c5FaL6ecL7thl1IiJ3Mk2c/rfApWMs95ryXYqsgrdzSdtfUPwCaOEZC3wvIfL6kW sZ9kRa/MndNQd6p5hP9ZUoncj6VsgRYhs5Y8kIs2/zN6a7+h909eimDzwM52Lmf/ZBmw e2tup4k5/zEEhi7G5n4Rl8QRFA545//Eh4nj2HfIokTpaaWpAgf3jKmIW4kFBufEni3y fUgmEXWAFtfUZ5tUwQJ0m+jl84TX13teG8JitmamxZTzpqztbPPztY7pt7FqJS9mMq1m Qhgr5CbEKhX8jGx9a6Heu5oUtT9crei9/fyZlHjRLloLM91LMJGxRETJQIVbOs6QCej6 eDeA== X-Gm-Message-State: ACrzQf1hU+8vfH53TG3PiPB5ptsAAQBTQzNkxg717KBV428xO527rel6 XJHH6OtQ9cLbA82PYFhT9M9H+xX5uqXpTj8g X-Google-Smtp-Source: AMsMyM4us6b5FmU4PeccH8nUGhgb7s/ly4QQ9iVdIo8qyYyTKIkpepZiNvRdYIDNnzjy2/+bkqualg== X-Received: by 2002:a05:6808:301e:b0:345:7d85:29d3 with SMTP id ay30-20020a056808301e00b003457d8529d3mr4046846oib.62.1663768619303; Wed, 21 Sep 2022 06:56:59 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:c266:cc93:9f8:1eba:d2e8? ([2804:1b3:a7c1:c266:cc93:9f8:1eba:d2e8]) by smtp.gmail.com with ESMTPSA id b129-20020acab287000000b00344f28a7a4csm1241576oif.22.2022.09.21.06.56.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 06:56:58 -0700 (PDT) Message-ID: <8602654c-c619-07b9-bf80-d6cb06030ce1@linaro.org> Date: Wed, 21 Sep 2022 10:56:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [committed] hppa: undef __ASSUME_SET_ROBUST_LIST Content-Language: en-US To: Florian Weimer , Adhemerval Zanella Netto via Libc-alpha References: <87illg3nao.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87illg3nao.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/09/22 09:49, Florian Weimer wrote: > * Adhemerval Zanella Netto via Libc-alpha: > >> On 20/09/22 17:20, John David Anglin wrote: >>> QEMU does not support support set_robust_list. Thus, we need >>> to enable detection of set_robust_list system call. >>> >>> Signed-off-by: John David Anglin >>> --- >>> diff --git a/sysdeps/unix/sysv/linux/hppa/kernel-features.h b/sysdeps/unix/sysv/linux/hppa/kernel-features.h >>> index 0cd21ef0fa..079612e4aa 100644 >>> --- a/sysdeps/unix/sysv/linux/hppa/kernel-features.h >>> +++ b/sysdeps/unix/sysv/linux/hppa/kernel-features.h >>> @@ -30,3 +30,6 @@ >>> >>> #undef __ASSUME_CLONE_DEFAULT >>> #define __ASSUME_CLONE_BACKWARDS 1 >>> + >>> +/* QEMU does not support set_robust_list. */ >>> +#undef __ASSUME_SET_ROBUST_LIST >>> >> >> Does it happen only for hppa? If is a generic missing feature maybe we should >> undef __ASSUME_SET_ROBUST_LIST for all architectures. > > I think it's just a 32-bit/64-bit mismatch issue. You can't create > 32-bit robust futexes from a 64-bit process because the pointer size in > the robust list differs. For non-process-shared mutexes, qemu-user > should be able to emulate these futexes in userspace. It already has to > intercept thread exit, and it can walk the mutex list at that time. > > I don't think it makes sense to pessimize bare-metal uses simply because > there's a qemu-user limitation. Should we revert the hppa fix then?