From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96140 invoked by alias); 20 Jul 2017 08:32:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96104 invoked by uid 89); 20 Jul 2017 08:32:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] S390: Sync ptrace.h with kernel. [BZ #21539] To: libc-alpha@sourceware.org References: <20170613200522.GA14306@altlinux.org> <20170718102039.GA20971@altlinux.org> <25569a51-e43c-9697-78e3-c319c9048763@redhat.com> <20170718133950.GA23830@altlinux.org> <85a36444-ca8b-5621-11f3-25c4083f0f92@linux.vnet.ibm.com> From: Stefan Liebler Cc: ldv@altlinux.org Date: Thu, 20 Jul 2017 08:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17072008-0012-0000-0000-000005647AA2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17072008-0013-0000-0000-000018D85167 Message-Id: <86689553-91fe-317f-77d8-a821087a064d@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-20_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707200139 X-SW-Source: 2017-07/txt/msg00728.txt.bz2 On 07/20/2017 10:06 AM, Carlos O'Donell wrote: > On 07/20/2017 03:38 AM, Stefan Liebler wrote: >> Carlos, shall we commit Dimitry's patch before the release? >> Then we don't have this regression compared to glibc 2.25 release. > > I'm OK with Dmitry's patch going in for 2.26 to fix the regression. Okay. > > Could you please work with Dmitry to get this committed? Okay. Dimitry, I have one small note to your patch: Can you add a space before the undefs and add the comment like this: (according to https://sourceware.org/glibc/wiki/Style_and_Conventions#Nested_C_Preprocessor_Directives) #if defined _LINUX_PTRACE_H || defined _S390_PTRACE_H /* Kludge to stop stuff gdb & strace compiles from getting upset */ # undef PTRACE_TRACEME ... #endif /* defined _LINUX_PTRACE_H || defined _S390_PTRACE_H */ Then the patch is okay. Can you please commit the patch? Otherwise, post the final patch, then I'll commit it. > > I'll work on fixing this coordination issue with the kernel when we > reopen for development. > Okay. Thanks. Stefan