Steward opinions on gerrit?

Steward opinions on gerrit?

[Carlos O'Donell]

As stewards for glibc I wanted to ask each of you if you had
any opinions on gerrit, and thoughts on or the fundamental
requirements of a review system for a project like glibc.

Joseph, 

You write and review a lot of patches. Does using gerrit
interest you? Does it solve any problems?

Andreas, 

Would you be interested in trying out gerrit? Does it solve
any problems for you as a reviewer?

Paul,

You comment on a lot of changes orthogonality, usually with
a broad perspective from various packages, would having reviews
in gerrit prevent this from happening during review?

-- 
Cheers,
Carlos.

Re: Steward opinions on gerrit?

[Joseph Myers]

On Wed, 27 Nov 2019, Carlos O'Donell wrote:

> As stewards for glibc I wanted to ask each of you if you had
> any opinions on gerrit, and thoughts on or the fundamental
> requirements of a review system for a project like glibc.
> 
> Joseph, 
> 
> You write and review a lot of patches. Does using gerrit
> interest you? Does it solve any problems?

I'm not convinced the experiment is advanced enough to tell whether it 
helps much.  The main problem I see patch review systems as being for is 
to track changes that are under consideration but not yet approved, and 
it's hard to judge when there are only a few changes in there.  (I suspect 
any system would gradually accumulate patches that were submitted by 
one-off contributors, issues raised, but never revised and never 
definitively rejected either.)

There's potential for various kinds of CI integration with patch tracking, 
but I don't think we've tried that.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: Steward opinions on gerrit?

[Carlos O'Donell]

On 11/27/19 5:47 PM, Joseph Myers wrote:
> On Wed, 27 Nov 2019, Carlos O'Donell wrote:
> 
>> As stewards for glibc I wanted to ask each of you if you had
>> any opinions on gerrit, and thoughts on or the fundamental
>> requirements of a review system for a project like glibc.
>>
>> Joseph, 
>>
>> You write and review a lot of patches. Does using gerrit
>> interest you? Does it solve any problems?
> 
> I'm not convinced the experiment is advanced enough to tell whether it 
> helps much.  The main problem I see patch review systems as being for is 
> to track changes that are under consideration but not yet approved, and 
> it's hard to judge when there are only a few changes in there.  (I suspect 
> any system would gradually accumulate patches that were submitted by 
> one-off contributors, issues raised, but never revised and never 
> definitively rejected either.
Gerrit does track changes under consideration, but falls down because it
doesn't accept email input at various stages and is non-robust in this case
if you clip the mail footer. I'm not happy about that.

I'd like to try Patchwork v2.0 and do a comparison.

> There's potential for various kinds of CI integration with patch tracking, 
> but I don't think we've tried that.
 
We have not yet tried that. We haven't gotten past making the new patch
tracking work well enough that we aren't doing too much manual work.

The problem with Patchwork v1.0 seemed to be that we needed a lot of manual
work to keep the patch queue clean and so we didn't do it.

-- 
Cheers,
Carlos.

Re: Steward opinions on gerrit?

[Andreas Schwab]

gerrit doesn't work with EWW.  That's a no-go.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: Steward opinions on gerrit?

[Carlos O'Donell]

On 12/9/19 5:54 AM, Andreas Schwab wrote:
> gerrit doesn't work with EWW.  That's a no-go.

Thanks for that feedback.

Can you try out a public patchwork 2.0 and see if it works?

For example can you browse and use:

https://patchwork.kernel.org/

Which is patchwork 2.0.

-- 
Cheers,
Carlos.

Re: Steward opinions on gerrit?

[Andreas Schwab]

On Dez 09 2019, Carlos O'Donell wrote:

> Can you try out a public patchwork 2.0 and see if it works?

That works fine, of course.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: Steward opinions on gerrit?

[Carlos O'Donell]

On 12/9/19 7:54 AM, Andreas Schwab wrote:
> On Dez 09 2019, Carlos O'Donell wrote:
> 
>> Can you try out a public patchwork 2.0 and see if it works?
> 
> That works fine, of course.

Awesome. Thank you for checking. I think with Siddhesh we're going
to see if we can try this out next.

I appreciate any feedback you're willing to give about this process.

-- 
Cheers,
Carlos.