From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xIkR=67=gentoo.org=arsen@sourceware.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	by sourceware.org (Postfix) with ESMTP id 6DB4B3858D39
	for <libc-alpha@sourceware.org>; Tue,  7 Mar 2023 09:30:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DB4B3858D39
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
References: <20230307003222.2810662-1-arsen@aarsen.me>
 <87bkl5q67n.fsf@oldenburg.str.redhat.com>
User-agent: mu4e 1.8.14; emacs 30.0.50
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@gentoo.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, carlos@redhat.com, toolchain@gentoo.org
Subject: Re: [PATCH v2] elf: Add -z lazy to some more tests
Date: Tue, 07 Mar 2023 10:23:54 +0100
In-reply-to: <87bkl5q67n.fsf@oldenburg.str.redhat.com>
Message-ID: <868rg8ykl4.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Florian Weimer <fweimer@redhat.com> writes:

> * Arsen Arsenovi=C4=87:
>
>> @@ -1612,6 +1631,7 @@ $(objpfx)multiload.out: $(objpfx)testobj1.so
>>  LDFLAGS-origtest =3D -rdynamic
>>  $(objpfx)origtest.out: $(objpfx)testobj1.so
>>=20=20
>> +$(objpfx)resolvfail.out: $(objpfx)testobj1.so
>>  ifeq ($(have-thread-library),yes)
>>  $(objpfx)resolvfail: $(shared-thread-library)
>>  endif
>
> Thsis seems unrelated?  I can see why it's needed, but please mention it
> in the commit message at least?

Ah, right.  I forgot about that entirely.

That test uses the testobj6, but doesn't depend on it.  If running the
elf/resolvfail test before make check, it's possible to see:

  FAIL: elf/resolvfail
  original exit status 1
  cannot load testobj1.so: testobj1.so: cannot open shared object file: No =
such file or directory

... which is fixed by just adding the dependency.  Will split into a new
commit and re-send.
=2D-=20
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOcEARYKAI8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZAcER18UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxEcYXJzZW5AZ2Vu
dG9vLm9yZwAKCRBSwpQwHqLEkwIgAQCaP6Cqm+2aSM01IpyCHOZeRgPcz2kw7H9V
A7KCktTq1gEAvA7kNKGjbICP1I2lY+Z/sHm1mgIcV1U7Rwmcr4YeQgI=
=wGqn
-----END PGP SIGNATURE-----
--=-=-=--