From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48436 invoked by alias); 1 Apr 2017 07:32:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48422 invoked by uid 89); 1 Apr 2017 07:32:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v3] Add page tests to string/test-strnlen. To: libc-alpha@sourceware.org, wainersm@linux.vnet.ibm.com References: <20170331203729.23812-1-wainersm@linux.vnet.ibm.com> From: Rajalakshmi Srinivasaraghavan Date: Sat, 01 Apr 2017 07:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170331203729.23812-1-wainersm@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17040107-0032-0000-0000-00000206CDEB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040107-0033-0000-0000-0000123B24C9 Message-Id: <86be702c-33dd-32f3-1937-d1507c0249d9@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-01_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704010073 X-SW-Source: 2017-04/txt/msg00002.txt.bz2 On 04/01/2017 02:07 AM, Wainer dos Santos Moschetta wrote: > I checked following the new cases aren't duplicated of string/stratcliff.c > tests. > > Changes since v2: > - Now using memset to initialize the string. > - Fixed indent of 2nd FOR_EACH_IMPL statement in do_page_test(), also > improved its explanation. > > --- >8 --- > May be tricky for otimized implementations to handle strings around > page boundary once, for instance, it is performed unaligned loads or > when maxlen is used as a hint for vectorized loops. The test cases > should unveil regression bugs on these cases. > > To some extend do_random_tests in string/test-strnlen tests strings > placed at page end but it does not cover all cases. So this change > adds tests which consists of placing strings of varying sizes ending > at the page boundary. It also combines with different values of maxlen. > > Tested on ppc64le and x86_64. > > 2017-03-31 Wainer dos Santos Moschetta > > * string/test-strnlen.c (do_page_tests): New function > to check length of strings ending at the page boundary. > (test_main): Added call to the do_page_tests function. LGTM -- Thanks Rajalakshmi S