From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 71DE83858D28 for ; Wed, 15 Dec 2021 01:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 71DE83858D28 Received: by mail-qt1-x82d.google.com with SMTP id t11so20269836qtw.3 for ; Tue, 14 Dec 2021 17:15:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UTwi66xAo8FPnfmcI6wMwRt6I1wy7SRQZcRJ9PuW1uY=; b=aUSwcVka5faUX39TtTi+dg9F3KM/7SwJYYtp0erupQQtNvkOS/XNMsa2YyVudSZaGQ MuevzIpUiCHCISIDC1B/tn0XiDENIHkyImltru3hDtIWZ2CI2O7TTEk0SlHyCXnklasE mhHWHLlhf4JUi7UnKQ84ZzIc9GkYgocsJD0CnsxkrnhLlRqRr3XxXkrPPUmGRENqWjKr rHKT66esKYANb2FpVRTtaT5Tv+4MlLDfpnupPWT1x0nokTLYf8hH/H74eFsIMmwWX5ug e+fGjkcROdiumWB11uzhTCXzNmDQGyS1diZP/GBIiPCcI0UavWZKbK/n6Y8bs8Z5Zluk vc1Q== X-Gm-Message-State: AOAM532hkkrAe/1wS5WYYjGZTkUb6HijoYQOEXto9+b1qBmyErjDbsqP 8fhNlz++AxGSLU3odMvRfhw/YGyT7vADvQ== X-Google-Smtp-Source: ABdhPJzt6IaxdwlbVn/YZe+lomKHddWTXc9gc7T0s5t/ygp4thlkEDZsXAC+SaDTh52W84iGZthuSg== X-Received: by 2002:a05:622a:454:: with SMTP id o20mr9991328qtx.217.1639530907808; Tue, 14 Dec 2021 17:15:07 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:1000:c46d:a2d6:9bed? ([2804:431:c7ca:103f:1000:c46d:a2d6:9bed]) by smtp.gmail.com with ESMTPSA id j22sm279571qko.68.2021.12.14.17.15.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Dec 2021 17:15:07 -0800 (PST) Message-ID: <86e61afa-ab95-62e1-10a7-3de71db8deb8@linaro.org> Date: Tue, 14 Dec 2021 22:15:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 03/13] or1k: ABI Implementation Content-Language: en-US To: Joseph Myers Cc: Stafford Horne , GLIBC patches , Openrisc References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-4-shorne@gmail.com> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 01:15:10 -0000 On 14/12/2021 19:43, Joseph Myers wrote: > On Tue, 14 Dec 2021, Adhemerval Zanella via Libc-alpha wrote: > >> +if test "x$profile" != xno; then >> + if test "x$with_profile" == xno; then >> + AC_MSG_ERROR([ABI does not support profiling]) > > Using == in test is a bashism. > > I'd expect such a change to require the build-many-glibcs.py configuration > for OpenRISC to use --disable-profile. > I ended up mixing up things and what or1k does not support is LD_PROFILE instead of --enable-profile. In this case I am not sure if it would be better to just not enable it (by ignoring the LD_PROFILE handling in rtld.c or dl-support.c) and emitting a warning or by just dumping and error at process initialization.