From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id A3E143858D39 for ; Tue, 7 Mar 2023 11:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3E143858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org References: <20230307102935.2882450-1-arsen@gentoo.org> <87fsagpz3g.fsf@oldenburg.str.redhat.com> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Florian Weimer Cc: libc-alpha@sourceware.org, carlos@redhat.com, toolchain@gentoo.org Subject: Re: [PATCH v3 1/2] elf,nptl: Add -z lazy to some more tests Date: Tue, 07 Mar 2023 12:53:25 +0100 In-reply-to: <87fsagpz3g.fsf@oldenburg.str.redhat.com> Message-ID: <86o7p4wzan.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Florian Weimer writes: > * Arsen Arsenovi=C4=87: > >> Some toolchains, such as that used on Gentoo Hardened, set -z now out of >> the box. This trips up a couple of tests. >> --- >> Hi, >> >> This is re-roll of the following patch series: >> https://inbox.sourceware.org/libc-alpha/20230307003222.2810662-1-arsen@a= arsen.me/ >> https://inbox.sourceware.org/libc-alpha/20230302112519.914641-1-arsen@ge= ntoo.org/ >> >> Changes from v2: >> - Split off the +$(objpfx)resolvfail.out: $(objpfx)testobj1.so change >> into its own commit. >> >> Changes from v1: >> - Dropped -z norelro. This turned out to be unnecessary after >> Adhemervals removal of --with-default-link and linker script >> machinery: >> https://patchwork.sourceware.org/project/glibc/list/?series=3D17843 >> See: https://inbox.sourceware.org/libc-alpha/86fsakz5mr.fsf@gentoo.org >> for an explanation of what caused the need for norelro. That fix was >> misguided, due to a previous error on my part, too. >> I applied this patch on top of that patchset and it would appear to >> resolve all related failures. >> The above is not applied to Git yet, but should be before this patch >> is. >> >> elf/Makefile | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> elf/Makefile | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) > > The patches look okay to me, but would you please resend them with > Signed-off-by: (to mark this as a contribution under DCO)? I had the > FSF records checked, and they don't have a glibc copyright assignment > from you, as far as we can tell. Sorry for the hassle! Yes, I never signed the copyright papers for the libc. I intended to undergo that process, which is why I didn't add signoffs initially (since they'd indicate that I don't intend to sign over copyright when I do), so I figured I should wait for advice. How should I proceed? Thanks in advance. PS: I noticed that I forgot to drop `,nptl' from the subject line. The NPTL bits of this patch are gone now. > > Thanks, > Florian =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOcEARYKAI8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZAcmUF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk8ovAP9mcxQOy/UowIVoq3Pf3HMrCgGX5Fze/hNN wnQnmz1KNQD+PgDK5dcyM6kGdMpinuYOChuxYlP5XFZXXXkq5FdGxAg= =shkL -----END PGP SIGNATURE----- --=-=-=--