From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 84C133849AEF for ; Sat, 13 Apr 2024 15:20:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84C133849AEF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84C133849AEF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713021631; cv=none; b=DxkoYgJa4Yibhkh2MuCzEc9D/68y5xkAWjti+L5CnpW2qFcH/Lo15yA3lwCPoBbrdx4R9RfxBgNdTPlKl44djfiLFqK24kcrp/+GLgjsx8DgqyeD5M5k68ONDdycbi/purNBnMCgufqxqJ5xxvhIgg4MVBL+ZiF4IFn/7BEe7Fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713021631; c=relaxed/simple; bh=X01xDFDl6Re6jgTVFtjJbHII72140OKOm7Hiv3k66m8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xcrJK78H9iwnXRR74N1inw3kqXG35ez5buI+w4Fxm++/s6SwRjundxcNIS6yJCDZ8JY9+5U/JXYt/TWc5e5Eq1phEpekt8tamhHB6EhPhDiTOl/uuUovjspRMUnl0SstUny0rWfypMQVZE+84zcp0u7QmML1UwtYx45kpjV9aHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713021629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7vLSc35x+il6PaPiHatMVrST6zSP7fhNIKnDAaa//ls=; b=ESLDNVp00CzA6QG4bsFuENy7615avguXO5+gHNyvYwSephX5tFTmNai3zQ0RDQqzAbvwNF o4kHoQ5ts0z/iwlI5H2iRHxLRuOyl6JelfT1nxH9X78uuhlG91iUmWcC6yzOP81IWYQsxu jBNJusH2ycdz728UQAjAxzG1vJ2wzNM= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-qORELHGhPMCZzxGIcQXHMw-1; Sat, 13 Apr 2024 11:20:27 -0400 X-MC-Unique: qORELHGhPMCZzxGIcQXHMw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A9FB1C05AAD; Sat, 13 Apr 2024 15:20:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 606337C28; Sat, 13 Apr 2024 15:20:26 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Sunil K Pandey Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" In-Reply-To: (H. J. Lu's message of "Sat, 13 Apr 2024 08:09:04 -0700") References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> Date: Sat, 13 Apr 2024 17:20:20 +0200 Message-ID: <871q792ssr.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: > On Sat, Apr 13, 2024 at 8:03=E2=80=AFAM Florian Weimer wrote: >> >> * H. J. Lu: >> >> > On Sat, Apr 13, 2024 at 7:49=E2=80=AFAM Florian Weimer wrote: >> >> >> >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680. >> >> >> >> The test failure is a real valgrind bug that needs to be fixed before >> >> valgrind is usable with a glibc that has been built with >> >> CC=3D"gcc -march=3Dx86-64-v3". The valgrind fix addresses the observ= ed >> >> test failure as well. >> >> >> >> Upstream bug: >> >> >> >> Tested on x86_64-linux-gnu with and without CC=3D"gcc -march=3Dx86-64= -v3". >> >> The elf/tst-valgrind-smoke tests again fails with an unpatched valgri= nd, >> >> and the proposed upstream patch fixes it. (Apparently, valgrind >> >> matches on soname, and not the file name, which is ld.so in the test.= ) >> > >> > Please clarify that your patch fixes the glibc valgrind test by not us= ing >> > strcmp-avx2.S in the valgrind test. >> >> Sorry, clarify where? In the commit message here? On the upstream bug? > > In the glibc commit message. > >> My valgrind patch replaces the strcmp implementation in ld.so with its >> own. >> > > Please mention it in the glibc commit message. Okay, I'll send a v2. Could someone proficient in x86-64 assembly have a look at my strcmp implementation? It seems to work, but =E2=80=A6 Thanks, Florian