From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 41D893858C3A for ; Fri, 16 Feb 2024 06:23:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41D893858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41D893858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708064626; cv=none; b=p3vhDSqeoSdSrS6X0/3ppIGBNgh4iqsEgDHCHjs7dq/NLvg02w4bfVu+Pyly/tBZHo/D0/WQtafoaFgxMcvL2Ai/Mz+SSYMwyJUd3xTIbsmOQK0BGj7nzTAv2dzx4ffm/3x6bdfT6H/rLiSF2Szy2CBpq+TApEeGBRH86POHqNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708064626; c=relaxed/simple; bh=ftVbv08TSTktv6zSRYlLze7sHDCIcVHZ3ScbowypNHU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ail1CCRWwcRhP0fxo/wLrC2YjqzC9aEpvwfF9rtotRQ3Iyew8cT27Tb8/crWXAQosMPDKtYgjRkjYWV3P/sXwFPPqTeaNQGRAYXqH5MeL/kMt235b+5MFfNM7crQdzaQsMdGOk2Dkno3Pjiu+FAMPgwGc8VlKRBIAbCHd/GL0gM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708064624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Vq/78PW7fD3hhWvKsUtDI2kupZWpp0y3hqX11iFJzw=; b=dz2guWNCDo7PH175w0L6UHutOT7i/wZEwUmZ4HlJ/l0pWEV4ESqwEA/GVGI8YPupLcJOS4 f4S5Sabq3bF+oxs829Q0+y3PQOpjyurjXerRXJVJTnqkZH9Tq+ITC0oBQBdh0iwdXdQoy4 MFR6dM+nJa/03KXHScm8cbcOy4IkdXc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348---avmqxJNsiUTvNol_ru1w-1; Fri, 16 Feb 2024 01:23:40 -0500 X-MC-Unique: --avmqxJNsiUTvNol_ru1w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 51B7338117EB; Fri, 16 Feb 2024 06:23:40 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1362AD77; Fri, 16 Feb 2024 06:23:38 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: "H.J. Lu" , libc-alpha@sourceware.org, Fangrui Song , Carlos O'Donell Subject: Re: [PATCH v4 2/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers References: <20240213041501.2494232-1-hjl.tools@gmail.com> <20240213041501.2494232-3-hjl.tools@gmail.com> Date: Fri, 16 Feb 2024 07:23:37 +0100 In-Reply-To: (Adhemerval Zanella Netto's message of "Thu, 15 Feb 2024 20:05:44 -0300") Message-ID: <871q9d7wra.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: >> diff --git a/elf/malloc-for-test.map b/elf/malloc-for-test.map >> new file mode 100644 >> index 0000000000..8437cf4346 >> --- /dev/null >> +++ b/elf/malloc-for-test.map >> @@ -0,0 +1,6 @@ >> +GLIBC_2.0 { > > You need to use the correct version to override the malloc: > > $ gdb --args tst-gnu2-tls2 --direct > [...] > (gdb) b apply_tls > (gdb) r > Thread 2 "tst-gnu2-tls2" hit Breakpoint 1, apply_tls (p=0x7ffff7bfee80) at tst-gnu2-tls2mod1.c:25 > 25 { > (gdb) b malloc > Breakpoint 2 at 0x7ffff7ca8ad0: malloc. (3 locations) > (gdb) c > Continuing. Why do we need to set a symbol version here? I think this can be removed. Thanks, Florian