From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 14E953858D28 for ; Fri, 31 Mar 2023 18:33:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14E953858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org References: <20230312000810.51652-1-alx@kernel.org> <70951a20-7444-0bd8-6e15-3fa1bcc28cb6@gmail.com> User-agent: mu4e 1.8.14; emacs 29.0.60 From: Sam James To: Alejandro Colomar Cc: Alejandro Colomar , Paul Eggert , Adhemerval Zanella Netto , libc-alpha@sourceware.org Subject: Re: Ping: [PATCH] time: Fix strftime(3) API regarding nullability Date: Fri, 31 Mar 2023 19:33:29 +0100 In-reply-to: <70951a20-7444-0bd8-6e15-3fa1bcc28cb6@gmail.com> Message-ID: <871ql4zs6y.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alejandro Colomar via Libc-alpha writes: > [[PGP Signed Part:Undecided]] > Ping :) > > On 3/13/23 18:10, Adhemerval Zanella Netto wrote: >>=20 >>=20 >> On 11/03/23 21:08, Alejandro Colomar via Libc-alpha wrote: >>> strftime(3) doesn't accept null pointers in any of the parameters. >>> >>> Cc: Paul Eggert >>> Signed-off-by: Alejandro Colomar >>=20 >> LGTM, thanks. >>=20 >> Reviewed-by: Adhemerval Zanella >>=20 >>> --- >>> time/time.h | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/time/time.h b/time/time.h >>> index d18089116e..28fb075b19 100644 >>> --- a/time/time.h >>> +++ b/time/time.h >>> @@ -99,7 +99,8 @@ extern time_t __REDIRECT_NTH (mktime, (struct tm *__t= p), __mktime64); >>> of characters written, or 0 if it would exceed MAXSIZE. */ >>> extern size_t strftime (char *__restrict __s, size_t __maxsize, >>> const char *__restrict __format, >>> - const struct tm *__restrict __tp) __THROW; >>> + const struct tm *__restrict __tp) >>> + __THROW __nonnull((1, 3, 4)); >>>=20=20 >>> #ifdef __USE_XOPEN >>> /* Parse S according to FORMAT and store binary time information in TP. Nice spot. I suspect there's a few more of these we need to fix too. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZCcnhV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZAFoQD/RKoTCvUSV+Sqfvx4b4S2y8ALR1WkA1zeNloq WhTfqZUA/3A7lHXkYSQo/xq+zV2bpkArKpe6Tbl1GNQUXQ9ziAwH =doz6 -----END PGP SIGNATURE----- --=-=-=--