From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3A3583858D33 for ; Thu, 16 Feb 2023 06:02:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A3583858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676527325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iM5uhpAQFTwNRSMOHefUdtNHaJr93Cm/jOjnospMpfg=; b=HkkoVyowx/nrXVmw24Pch8bqgar9VPo+dfyZyD5H0t4P8jOjzrCQQFkysAUaVobeey1e09 vhNjKgXoJx32K77nQNTZpowTNKSvim/YzDQuHYaf1/uB8GXsC1jfhuX15Oeo/bu2AOrLBN gXbfciG6+1vCgHyHX2Z9cuUX/QO+IYE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-135-WuhCBEMZPJqai8FvqJLByA-1; Thu, 16 Feb 2023 01:02:02 -0500 X-MC-Unique: WuhCBEMZPJqai8FvqJLByA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC5E0830F4E; Thu, 16 Feb 2023 06:02:01 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8605140EBF6; Thu, 16 Feb 2023 06:02:00 +0000 (UTC) From: Florian Weimer To: Joan Bruguera via Libc-alpha Cc: Joan Bruguera , adhemerval.zanella@linaro.org Subject: Re: [PATCH] elf: Restore lconfig libc6 implicit soname logic [BZ #30125] References: <20230216022355.3954438-1-joanbrugueram@gmail.com> Date: Thu, 16 Feb 2023 07:01:59 +0100 In-Reply-To: <20230216022355.3954438-1-joanbrugueram@gmail.com> (Joan Bruguera via Libc-alpha's message of "Thu, 16 Feb 2023 02:23:55 +0000") Message-ID: <871qmqrvvs.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Joan Bruguera via Libc-alpha: >>> >>>> Signed-off-by: Joan Bruguera >>> >>> We do not signed-off-by on glibc, so no need for it. >>> >> >> https://sourceware.org/glibc/wiki/Contribution%20checklist#Developer_Certificate_of_Origin says we do? > > Hmmm, indeed, after re-re-reviewing this document, I understand (hopefully > correctly) that I indeed *must* include the Signed-off-by header, as I am not > covered by a copyright assignment to the FSF. Yes, that's true. > I have submitted a v3 adding the Signed-off-by as well as a > "Copyright The GNU Toolchain Authors." header to the new test, > additionally to a "Copyright (C) 2000-2023 Free Software Foundation, Inc." > (as the test structure is based on tst-ldconfig-X.sh.) > Apologies if *not* adding the "Copyright The GNU Toolchain Authors." header in > the previous mail made the reviewer think I was covered by a FSF assignment. That's what I've been doing in similar cases. Thanks for the attention to detail. Florian