From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=sXQB=6B=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id 06FB83858D32
	for <libc-alpha@sourceware.org>; Sun,  5 Feb 2023 20:08:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06FB83858D32
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1675627704;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7gzj8biIlTmxDvLgf6JM20mMis/53Nqxx6De7ZfkeDM=;
	b=ZNZ87db8jeWi7aUaNfTT+1VJf5ghqfckrLVsulpjxCi6FhPYovyS4C2bsHFOC/GfKPSb9E
	IwE+qSUP0frzvyAUsSLJOJubt76+RsNb53p6sO0hrpd+QizA86PxSMK6boBKQEeYdQaIb+
	rf0+4X3lH0PD4Vato4NuFynu7p84znc=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-81-i-K77clwNmqmWG9OqnVEsA-1; Sun, 05 Feb 2023 15:08:23 -0500
X-MC-Unique: i-K77clwNmqmWG9OqnVEsA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B28E985CBE2;
	Sun,  5 Feb 2023 20:08:22 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.7])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 737132026D37;
	Sun,  5 Feb 2023 20:08:21 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,  Szabolcs Nagy
 <szabolcs.nagy@arm.com>,  Rich Felker <dalias@libc.org>,  Paul Pluzhnikov
 via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert
 implementation in C++
References: <CALoOobP+sGwmAA-14zxN+T_oxcdy-Nhfc-0qECZYsFvFNCKk1A@mail.gmail.com>
	<871qnlfhtv.fsf@oldenburg.str.redhat.com>
	<20230124111019.GC3298@brightrain.aerifal.cx>
	<878rhsgoxn.fsf@oldenburg.str.redhat.com>
	<20230124112307.GE3298@brightrain.aerifal.cx>
	<CACb0b4nXwwY73Eo3kFQ+cHs10GLgRd7SX15-YJo9EBV6hK6Piw@mail.gmail.com>
	<87zga8f83f.fsf@oldenburg.str.redhat.com>
	<CACb0b4nCx6MT+LSzMDo-k-9FODd3efb0YZ+YH7+UroJYp5bCxg@mail.gmail.com>
	<Y8/0O3XmWK+GJkCG@arm.com>
	<CACb0b4mOiRtajHKp=HeM4-pb=7=A0qtR0tnEX+9SqJ1ceMVfvQ@mail.gmail.com>
	<CALoOobNabo-6s1acjUCS9b2j+W1VfdcZV5AA7DX7LxU8kkQqSw@mail.gmail.com>
	<CACb0b4kB-e0W+4Kx4yw6MKnpCEKoiBV3rxL0FwKyMgOhM+royg@mail.gmail.com>
	<CALoOobPysmS=ZJ_wMdogs1zqBBKPtR13akErpC8RcRJ+h3Uf5Q@mail.gmail.com>
Date: Sun, 05 Feb 2023 21:08:19 +0100
In-Reply-To: <CALoOobPysmS=ZJ_wMdogs1zqBBKPtR13akErpC8RcRJ+h3Uf5Q@mail.gmail.com>
	(Paul Pluzhnikov's message of "Sun, 5 Feb 2023 10:39:12 -0800")
Message-ID: <871qn3yix8.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Paul Pluzhnikov:

> Are there any strong objections to this patch which haven't been addressed?
>
> It seems that
> - it's a complete no-op in plain-C
> - it helps C++ modules
> - it has no real negatives
>
> and as such should be a "no brainer".

As I said before, use of these builtins needs to be conditionalized.

Thanks,
Florian