From: Florian Weimer <fweimer@redhat.com>
To: Fangrui Song <maskray@google.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
libc-alpha@sourceware.org,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: x86_64 / i686 no-PIE failures
Date: Fri, 04 Nov 2022 18:47:10 +0100 [thread overview]
Message-ID: <871qqizk69.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20221104172825.7suwsbpdzvs5tqkt@google.com> (Fangrui Song's message of "Fri, 4 Nov 2022 10:28:25 -0700")
* Fangrui Song:
> On 2022-11-04, Florian Weimer wrote:
>>* H. J. Lu:
>>> Given the linker change, we should drop these tests for non-PIE.
>
> Agree.
> https://sourceware.org/git/?p=glibc.git;a=commit;h=66a273d16a63d1ed74a8d14a210a04c6a0f5dd45
> ("elf: Disable ifuncmain{1,5,5pic,5pie} when using LLD")
> disabled some tests about exe's direct references to protected DSO symbols.
> binutils ports (aarch64 and x86) which have the strict behavior need to
> disable the tests as well.
>
>>If we don't take the address of foo_protected, we'd only have an
>>X86_64_PLT32 relocation. Would that be valid from a linker perspective?
> R_X86_64_PLT32 is a PLT-generating relocation, not a direct reference.
> It is compatible with a protected definition in a DSO.
Thanks, I'm testing a patch.
Florian
prev parent reply other threads:[~2022-11-04 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 22:27 Joseph Myers
2022-11-04 7:12 ` Florian Weimer
2022-11-04 9:28 ` Szabolcs Nagy
2022-11-04 16:48 ` H.J. Lu
2022-11-04 16:52 ` Florian Weimer
2022-11-04 17:28 ` Fangrui Song
2022-11-04 17:47 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qqizk69.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).