From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 651FD38515DC
 for <libc-alpha@sourceware.org>; Wed, 25 May 2022 12:01:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 651FD38515DC
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-101-eTw6QbXJPbObon_yaPFOXg-1; Wed, 25 May 2022 08:01:33 -0400
X-MC-Unique: eTw6QbXJPbObon_yaPFOXg-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75207294EDC2;
 Wed, 25 May 2022 12:01:33 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.193.94])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CF431121314;
 Wed, 25 May 2022 12:01:32 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: ffix required
References: <3e4eb74b-0f99-1dfe-9dd4-9cf3039a1f89@gmail.com>
Date: Wed, 25 May 2022 14:01:30 +0200
In-Reply-To: <3e4eb74b-0f99-1dfe-9dd4-9cf3039a1f89@gmail.com> (Alejandro
 Colomar's message of "Tue, 24 May 2022 23:02:43 +0200")
Message-ID: <871qwhzuqt.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2022 12:01:36 -0000

* Alejandro Colomar:

> $ grepc ucontext_t ./sysdeps/unix/sysv/linux/x86/sys/ucontext.h
> ./sysdeps/unix/sysv/linux/x86/sys/ucontext.h:133:
> typedef struct
>   {
>     gregset_t __ctx(gregs);
>     /* Note that fpregs is a pointer.  */
>     fpregset_t __ctx(fpregs);
>     __extension__ unsigned long long __reserved1 [8];
> } mcontext_t;

What would you do if this turned into this?

typedef struct {
    gregset_t __ctx(gregs);
    /* Note that fpregs is a pointer.  */
    fpregset_t __ctx(fpregs);
    __extension__ unsigned long long __reserved1 [8];
} mcontext_t;

It's probably not how we'd fix this (it's not really GNU style), but
other projects might use that.

Thanks,
Florian