From: Andreas Schwab <schwab@linux-m68k.org>
To: Wilco Dijkstra via Libc-alpha <libc-alpha@sourceware.org>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: Re: [PATCH] Avoid RMW of flags2 outside lock (BZ #27842)
Date: Thu, 19 May 2022 17:25:23 +0200 [thread overview]
Message-ID: <871qwpwnmk.fsf@igel.home> (raw)
In-Reply-To: <DB6PR0801MB187958646D1DCDD920EA00F183D09@DB6PR0801MB1879.eurprd08.prod.outlook.com> (Wilco Dijkstra via Libc-alpha's message of "Thu, 19 May 2022 15:10:22 +0000")
On Mai 19 2022, Wilco Dijkstra via Libc-alpha wrote:
> Remove an unconditional RMW on flags2 in flockfile - if _IO_FLAGS2_NEED_LOCK
> is set, we are single-threaded and we can safely clear the flag.
Isn't that backwards? In single-theaded case, the flags is normally not
set, and it can safely be set.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-05-19 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 15:10 Wilco Dijkstra
2022-05-19 15:25 ` Andreas Schwab [this message]
2022-05-19 15:47 ` Adhemerval Zanella
2022-05-19 16:26 ` Wilco Dijkstra
2022-05-19 16:57 ` Adhemerval Zanella
2022-05-20 10:34 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qwpwnmk.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).