From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 8A93B3858D35 for ; Fri, 10 Dec 2021 13:53:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A93B3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4J9XRN1gGtz1sF4j; Fri, 10 Dec 2021 14:53:04 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4J9XRN1FXWz1qqkC; Fri, 10 Dec 2021 14:53:04 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id nImir2_iydHV; Fri, 10 Dec 2021 14:53:03 +0100 (CET) X-Auth-Info: ++YcgcqcUE4Mqa+IMgiDnEkgx//Rna6kW/BAK+qzOwPuXPlTCC/uYAvR4t1Dp0zK Received: from igel.home (ppp-46-244-172-32.dynamic.mnet-online.de [46.244.172.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 10 Dec 2021 14:53:03 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 976712C37EC; Fri, 10 Dec 2021 14:53:02 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Cc: Florian Weimer , Adhemerval Zanella Subject: Re: [PATCH v2 2/2] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ #28350) References: <20210929140619.279302-1-adhemerval.zanella@linaro.org> <20210929140619.279302-2-adhemerval.zanella@linaro.org> <878rwsbrri.fsf@oldenburg.str.redhat.com> <32567bed-9014-3db5-371a-56d4a8420966@linaro.org> <87zgp88vpm.fsf@oldenburg.str.redhat.com> <87v8zw8vl7.fsf@oldenburg.str.redhat.com> <297f0df8-c38c-996f-c3f4-f532f24ecff2@linaro.org> <87ilvw8tqv.fsf@oldenburg.str.redhat.com> <8538f1fc-cac4-06d5-010c-6600dd4357db@linaro.org> X-Yow: Are you guys lined up for the METHADONE PROGRAM or FOOD STAMPS?? Date: Fri, 10 Dec 2021 14:53:02 +0100 In-Reply-To: <8538f1fc-cac4-06d5-010c-6600dd4357db@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 10 Dec 2021 10:44:58 -0300") Message-ID: <871r2klg75.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 13:53:08 -0000 On Dez 10 2021, Adhemerval Zanella via Libc-alpha wrote: > I think the indentation change made the patch hard to read, the issues is > currently we have: > > for (cmsg = CMSG_FIRSTHDR (msg); > cmsg != NULL; > cmsg = CMSG_NXTHDR (msg, cmsg)) > { > if (cmsg->cmsg_level != SOL_SOCKET) > continue; > [...] > last = cmsg; > } > > Where we need 'last' to updated regardless of 'cmsg_level': > > for (cmsg = CMSG_FIRSTHDR (msg); > cmsg != NULL; > cmsg = CMSG_NXTHDR (msg, cmsg)) > { > if (cmsg->cmsg_level == SOL_SOCKET) > [...] > last = cmsg; > } You could move the assignment in the loop header so that continue continues to work. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."