public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Fāng-ruì Sòng" <maskray@google.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Add elf checks for main executable
Date: Wed, 08 Dec 2021 11:19:20 +0100	[thread overview]
Message-ID: <871r2nmmaf.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAFP8O3KMYAkELq-s-wZxz_kj-U5-S-jioKZxrmhDfktT_z=m1A@mail.gmail.com> (=?utf-8?B?IkbEgW5nLXJ1w6wgU8OybmciJ3M=?= message of "Tue, 7 Dec 2021 19:01:58 -0500")

* Fāng-ruì Sòng:

> On Tue, Dec 7, 2021 at 12:35 PM Adhemerval Zanella via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>>
>>
>> On 07/12/2021 12:45, Florian Weimer wrote:
>> > * Adhemerval Zanella:
>> >
>> >> It does, but only for specific configurations.  bintutils does have a
>> >> testcase for it, pr21375*, but not all configurations does bump because
>> >> they do not require ABS relocations (for instance, for n64 -mmicromips
>> >> --defsym hidn=1 does set the ABI version to 4).
>> >
>> > Should this tell us something at DT_RELR?  That binutils doesn't help us
>> > to prevent crashes for other features?
>>
>> I think it tell us that binutils support for DT_RELR or any other potential
>> abi disruptive feature will need a better ABI enforce for all Linux or
>> affected ABI.  It seems that binutils support are not really unified with
>> the multiples architectures and ABI.
>>
>> But I think it should be doable on linker side.
>
> For DT_RELR, you may see
> https://maskray.me/blog/2021-10-31-relative-relocations-and-relr#ei_abiversion
> Many Linux executables (STB_GNU_UNIQUE/STT_GNU_IFUNC are not used) use
> ELFOSABI_NONE and the linker does not and should not bump
> EI_ABIVERSION.

That radare2 command is really confusing.  It changes the ABI version to
16.  It does not change OSABI to GNU.

So I think we actually agree on the ld behavior, that the
OSABI/ABIVERSION is not really used by binutils today.

One question I meant to ask you: If the GNU toolchain uses any mechanism
for lockout of older glibc, would Google start building binaries using
that mechanism and patch their glibc forks that implement DT_RELR to be
able to load binaries with the lockout?

Thanks,
Florian


  reply	other threads:[~2021-12-08 10:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 15:03 Adhemerval Zanella
2021-11-19 15:33 ` H.J. Lu
2021-11-19 16:05   ` H.J. Lu
2021-11-19 17:06     ` Adhemerval Zanella
2021-12-06 19:03 ` H.J. Lu
2021-12-06 19:09 ` Florian Weimer
2021-12-06 19:22   ` H.J. Lu
2021-12-06 20:31     ` Adhemerval Zanella
2021-12-06 20:37       ` Florian Weimer
2021-12-06 21:07         ` Adhemerval Zanella
2021-12-07 15:45           ` Florian Weimer
2021-12-07 17:35             ` Adhemerval Zanella
2021-12-08  0:01               ` Fāng-ruì Sòng
2021-12-08 10:19                 ` Florian Weimer [this message]
2021-12-14  0:17                   ` Fāng-ruì Sòng
2021-12-14  9:03                     ` Florian Weimer
2021-12-14  9:09                       ` Fāng-ruì Sòng
2021-12-14  9:18                         ` Florian Weimer
2021-12-14 19:03                           ` Fangrui Song
2021-12-14 12:28                         ` Adhemerval Zanella
2021-12-14 12:23                       ` Adhemerval Zanella
2021-12-14 19:24                         ` Fangrui Song
2021-12-14 21:07                           ` Adhemerval Zanella
2021-12-14 21:30                             ` Fangrui Song
2021-12-14 21:53                               ` Florian Weimer
2021-12-14 23:08                                 ` Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r2nmmaf.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).