From: Andreas Schwab <schwab@linux-m68k.org>
To: Matheus Castanho via Libc-alpha <libc-alpha@sourceware.org>
Cc: Matheus Castanho <msc@linux.ibm.com>, murphyp@linux.ibm.com
Subject: Re: [PATCH v2] powerpc64[le]: Fix CFI and LR save address for asm syscalls [BZ #28532]
Date: Wed, 24 Nov 2021 15:08:41 +0100 [thread overview]
Message-ID: <871r35ir2u.fsf@igel.home> (raw)
In-Reply-To: <20211124132912.175073-1-msc@linux.ibm.com> (Matheus Castanho via Libc-alpha's message of "Wed, 24 Nov 2021 10:29:12 -0300")
On Nov 24 2021, Matheus Castanho via Libc-alpha wrote:
> diff --git a/sysdeps/powerpc/powerpc64/sysdep.h b/sysdeps/powerpc/powerpc64/sysdep.h
> index 589f7c8d18..c751bc76f9 100644
> --- a/sysdeps/powerpc/powerpc64/sysdep.h
> +++ b/sysdeps/powerpc/powerpc64/sysdep.h
> @@ -275,12 +275,14 @@ LT_LABELSUFFIX(name,_name_end): ; \
> /* Allocate frame and save register */
> #define NVOLREG_SAVE \
> stdu r1,-SCV_FRAME_SIZE(r1); \
> + cfi_adjust_cfa_offset(SCV_FRAME_SIZE); \
> std r31,SCV_FRAME_NVOLREG_SAVE(r1); \
> - cfi_adjust_cfa_offset(SCV_FRAME_SIZE);
> + cfi_offset(r31,-(SCV_FRAME_SIZE-SCV_FRAME_NVOLREG_SAVE));
Perhaps use cfi_rel_offset instead.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-11-24 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 14:22 [PATCH] powerpc64[le]: Fix CFI for assembly templated " Matheus Castanho
2021-11-03 15:46 ` Paul E Murphy
2021-11-03 16:41 ` Matheus Castanho
2021-11-04 22:36 ` Paul E Murphy
2021-11-24 13:29 ` [PATCH v2] powerpc64[le]: Fix CFI and LR save address for asm " Matheus Castanho
2021-11-24 14:08 ` Andreas Schwab [this message]
2021-11-26 21:29 ` Matheus Castanho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r35ir2u.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
--cc=msc@linux.ibm.com \
--cc=murphyp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).