From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A5AF43858036 for ; Fri, 12 Nov 2021 13:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A5AF43858036 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-jnTMzCKqPCmmuPoC9Fp4CA-1; Fri, 12 Nov 2021 08:14:01 -0500 X-MC-Unique: jnTMzCKqPCmmuPoC9Fp4CA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 11DE41091360; Fri, 12 Nov 2021 13:14:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34CD55D6D5; Fri, 12 Nov 2021 13:13:59 +0000 (UTC) From: Florian Weimer To: Florian Weimer via Libc-alpha Cc: schwab@linux-m68k.org Subject: Re: [PATCH] elf: Fix glibc-hwcaps priorities with cache flags mismatches [BZ #27046] References: <87wnqmc9m2.fsf@oldenburg.str.redhat.com> Date: Fri, 12 Nov 2021 14:13:57 +0100 In-Reply-To: <87wnqmc9m2.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Tue, 22 Jun 2021 15:27:49 +0200") Message-ID: <871r3lsei2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 13:14:06 -0000 * Florian Weimer via Libc-alpha: > If lib->flags (in the cache) did not match GLRO (dl_correct_cache_id), > searching for further glibc-hwcaps entries did not happen, and it > was possible that the best glibc-hwcaps was not found. By accident, > this causes a test failure for elf/tst-glibc-hwcaps-prepend-cache > on armv7l. > > This commit changes the cache lookup logic to continue searching > if (a) no match has been found, (b) a named glibc-hwcaps match > has been found(), or (c) non-glibc-hwcaps match has been found > and the entry flags and cache default flags do not match. > > _DL_CACHE_DEFAULT_ID is used instead of GLRO (dl_correct_cache_id) > because the latter is only written once on i386 if loading > of libc.so.5 libraries is selected, so GLRO (dl_correct_cache_id) > should probably removed in a future change. > > Tested on i686-linux-gnu, x86_64-linux-gnu, and on an armv7l system that > exposed the issue. Most of the diff is due to whitespace changes. Ping? Is there still interest in fixing this for 32-bit Arm? Thanks, Florian