public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v11 2/2] Add generic C.UTF-8 locale (Bug 17318)
Date: Mon, 06 Sep 2021 17:13:09 +0200	[thread overview]
Message-ID: <871r61yby2.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210906151122.481858-3-carlos@redhat.com> (Carlos O'Donell's message of "Mon, 6 Sep 2021 11:11:22 -0400")

* Carlos O'Donell:

> The locale is harmonized with locales already shipping in Gentoo,
> Debian, Ubuntu, Fedora, CentOS Stream, and RHEL. A new tst-iconv9 test
> is added which verifies the C.UTF-8 locale is generally usable.

One more nit, please aligned paragraph above with what's in NEWS.

Otherwise:

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2021-09-06 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 15:11 [PATCH v11 0/2] C.UTF-8 Carlos O'Donell
2021-09-06 15:11 ` [PATCH v11 1/2] Add 'codepoint_collation' support for LC_COLLATE Carlos O'Donell
2021-09-06 15:11 ` [PATCH v11 2/2] Add generic C.UTF-8 locale (Bug 17318) Carlos O'Donell
2021-09-06 15:13   ` Florian Weimer [this message]
2021-09-06 15:24     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r61yby2.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).