From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 439A13857434 for ; Wed, 7 Jul 2021 12:53:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 439A13857434 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-vusVvvsjPxqtCsTjUTgE7A-1; Wed, 07 Jul 2021 08:53:12 -0400 X-MC-Unique: vusVvvsjPxqtCsTjUTgE7A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D3C8804140; Wed, 7 Jul 2021 12:53:11 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A10D45D6A8; Wed, 7 Jul 2021 12:53:10 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v7 2/4] linux: Add close_range References: <20210706145839.1658623-1-adhemerval.zanella@linaro.org> <20210706145839.1658623-3-adhemerval.zanella@linaro.org> <87fswqa0eo.fsf@oldenburg.str.redhat.com> <9c726db9-9744-8030-a708-02454b8ecd26@linaro.org> Date: Wed, 07 Jul 2021 14:53:08 +0200 In-Reply-To: <9c726db9-9744-8030-a708-02454b8ecd26@linaro.org> (Adhemerval Zanella's message of "Wed, 7 Jul 2021 09:51:42 -0300") Message-ID: <871r8a8evf.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 12:53:17 -0000 * Adhemerval Zanella: > I changed it to the following, since afaiu kernel ignores gaps and our > fallback also ignore close return code. > > /* Close all file descriptors in the range FD up to MAX_FD. The flag FLAGS > are define by the CLOSE_RANGE prefix. This function behaves like close > on the range, but in a fail-safe where it will either fail and not close > any file descriptor or close all of them. Gaps where the file descriptor > is invalid are ignored. Returns 0 on successor or -1 for failure (and > sets errno accordingly). */ Okay, thanks for fine-tuning this. Florian