From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id A9AB03857824; Wed, 16 Jun 2021 15:29:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9AB03857824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4G4pxn2KFBz1s46n; Wed, 16 Jun 2021 17:29:01 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4G4pxn19C6z1qqkt; Wed, 16 Jun 2021 17:29:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id w0Cd3JPBq1kX; Wed, 16 Jun 2021 17:29:00 +0200 (CEST) X-Auth-Info: KrEPK+aJrdYsoVTSlKIGtWuxl+xNKgBHrMx7ix5IZHHZC6ihFPJgY+IJtB4v0kry Received: from igel.home (ppp-46-244-160-108.dynamic.mnet-online.de [46.244.160.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 16 Jun 2021 17:29:00 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id C7E242C2FBD; Wed, 16 Jun 2021 17:28:59 +0200 (CEST) From: Andreas Schwab To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org, dj@redhat.com Subject: Re: [PATCH 2/6] gconv_conf: Remove unused variables References: <20210610111853.2286873-1-siddhesh@sourceware.org> <20210610111853.2286873-3-siddhesh@sourceware.org> X-Yow: Can I have an IMPULSE ITEM instead? Date: Wed, 16 Jun 2021 17:28:59 +0200 In-Reply-To: <20210610111853.2286873-3-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Thu, 10 Jun 2021 16:48:49 +0530") Message-ID: <871r91rfpg.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 15:29:04 -0000 On Jun 10 2021, Siddhesh Poyarekar wrote: > The modules and nmodules parameters passed to add_modules, add_alias, > etc. are not used and are hence unnecessary. Remove them so that > their signatures match the functions in iconvconfig. Ok. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."