Re: [PATCH 3/3] nptl: Move pthread_cancel into libc

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella:

> On 11/05/2021 14:37, Florian Weimer wrote:
>> * Adhemerval Zanella:
>> 
>>>> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h
>>>> index 1692788528..5b844f331a 100644
>>>> --- a/nptl/pthreadP.h
>>>> +++ b/nptl/pthreadP.h
>>>> @@ -521,7 +521,6 @@ extern pthread_t __pthread_self (void);
>>>>  extern int __pthread_equal (pthread_t thread1, pthread_t thread2);
>>>>  extern int __pthread_detach (pthread_t th);
>>>>  libc_hidden_proto (__pthread_detach)
>>>> -extern int __pthread_cancel (pthread_t th);
>>>>  extern int __pthread_kill (pthread_t threadid, int signo);
>>>>  extern void __pthread_exit (void *value) __attribute__ ((__noreturn__));
>>>>  libc_hidden_proto (__pthread_exit)
>>>
>>> I am kinda puzzled how the libc_hidden_proto work without the __pthread_cancel
>>> prototype.
>> 
>> Sorry, I don't understand the question?  Did I leave libc_hidden_def
>> somewhere by mistake?
>
> No, it is from where libc_hidden_proto gets __pthread_cancel
> definition to use on its internal __typeof.

There's no libc_hidden_proto (__pthread_cancel) before or after this
patch.  Sorry for being terse, I really don't get what you are after.

Florian