From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0B7A4388E809 for ; Tue, 11 May 2021 18:18:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0B7A4388E809 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-xaLqZslmNT2qXOZp3mVE1Q-1; Tue, 11 May 2021 14:18:23 -0400 X-MC-Unique: xaLqZslmNT2qXOZp3mVE1Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4C69107ACF3; Tue, 11 May 2021 18:18:22 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE2C414103; Tue, 11 May 2021 18:18:21 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 3/3] nptl: Move pthread_cancel into libc References: <1c9e0befaa92592c8f6488c1235ebbfe39d0a61c.1620730539.git.fweimer@redhat.com> <76ab35d6-8a65-921a-59ab-be4e0418afba@linaro.org> <87k0o5xjcp.fsf@oldenburg.str.redhat.com> <341d783d-5432-8cfa-b071-6561902b817d@linaro.org> Date: Tue, 11 May 2021 20:18:49 +0200 In-Reply-To: <341d783d-5432-8cfa-b071-6561902b817d@linaro.org> (Adhemerval Zanella's message of "Tue, 11 May 2021 15:13:50 -0300") Message-ID: <871radxhfa.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 18:18:30 -0000 * Adhemerval Zanella: > On 11/05/2021 14:37, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>>> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h >>>> index 1692788528..5b844f331a 100644 >>>> --- a/nptl/pthreadP.h >>>> +++ b/nptl/pthreadP.h >>>> @@ -521,7 +521,6 @@ extern pthread_t __pthread_self (void); >>>> extern int __pthread_equal (pthread_t thread1, pthread_t thread2); >>>> extern int __pthread_detach (pthread_t th); >>>> libc_hidden_proto (__pthread_detach) >>>> -extern int __pthread_cancel (pthread_t th); >>>> extern int __pthread_kill (pthread_t threadid, int signo); >>>> extern void __pthread_exit (void *value) __attribute__ ((__noreturn__)); >>>> libc_hidden_proto (__pthread_exit) >>> >>> I am kinda puzzled how the libc_hidden_proto work without the __pthread_cancel >>> prototype. >> >> Sorry, I don't understand the question? Did I leave libc_hidden_def >> somewhere by mistake? > > No, it is from where libc_hidden_proto gets __pthread_cancel > definition to use on its internal __typeof. There's no libc_hidden_proto (__pthread_cancel) before or after this patch. Sorry for being terse, I really don't get what you are after. Florian