From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 38E09388C014 for ; Thu, 6 May 2021 15:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 38E09388C014 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-F3H5ndBmO_GMgGBPHpoOGg-1; Thu, 06 May 2021 11:23:26 -0400 X-MC-Unique: F3H5ndBmO_GMgGBPHpoOGg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6776F1008063; Thu, 6 May 2021 15:23:25 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E91219D61; Thu, 6 May 2021 15:23:24 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH] Run $(objpfx)iconvconfig as an installed program References: <20210226211507.3430032-1-hjl.tools@gmail.com> Date: Thu, 06 May 2021 17:23:43 +0200 In-Reply-To: <20210226211507.3430032-1-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Fri, 26 Feb 2021 13:15:07 -0800") Message-ID: <871rajhon4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 15:23:30 -0000 * H. J. Lu via Libc-alpha: > diff --git a/iconv/Makefile b/iconv/Makefile > index 659857dd8c..4af3eea0d8 100644 > --- a/iconv/Makefile > +++ b/iconv/Makefile > @@ -95,11 +95,13 @@ $(inst_bindir)/iconv: $(objpfx)iconv_prog $(+force) > $(objpfx)iconv_prog: $(iconv_prog-modules:%=$(objpfx)%.o) > $(objpfx)iconvconfig: $(iconvconfig-modules:%=$(objpfx)%.o) > > -$(objpfx)test-iconvconfig.out: /dev/null $(objpfx)iconvconfig > +$(objpfx)test-iconvconfig.out: $(objpfx)iconvconfig > (set -e; \ > tmp=$(objpfx)gconv-modules.cache.$$$$; \ > rm -f $$tmp; \ > - $(make-test-out) --output=$$tmp --nostdlib $(inst_gconvdir); \ > + $(built-program-cmd-before-env) \ > + $(run-program-env) $(built-program-cmd-after-env) $< \ > + --output=$$tmp --nostdlib $(inst_gconvdir); \ > cmp $$tmp $(inst_gconvdir)/gconv-modules.cache; \ > rm -f $$tmp) > $@; \ > $(evaluate-test) Should tests use $(test-wrapper-env) instead of $(run-program-env) $(built-program-cmd-after-env)? I think it's commonly used (mostly along with shell scripts though). Thanks, Florian