From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: ld.so --help calls _dl_init_paths without a main map [BZ #27577]
Date: Mon, 15 Mar 2021 13:14:57 +0100 [thread overview]
Message-ID: <871rcgwr3y.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOpeMsKWJHAmca9OpejciutkBp6-De=-Qi-jiXW5c_e7tA@mail.gmail.com> (H. J. Lu's message of "Mon, 15 Mar 2021 05:10:26 -0700")
* H. J. Lu:
>> +$(objpfx)tst-rtld-help.out: $(objpfx)ld.so
>> + $(test-wrapper) $(rtld-prefix) --help > $@; \
>> + $(evaluate-test)
>> +$(objpfx)tst-rtld-help-2.out: $(objpfx)tst-rtld-help.out
>> + grep -q 'Legacy HWCAP subdirectories under library search path directories' $<; \
>> + $(evaluate-test)
>
> Can we avoid tst-rtld-help-2.out by grep $@ directly?
We could use &&, but that would make diagnosing test failures difficult
(as in: did --help fail, or grep?). The separate test seemed the
easiest way.
Thanks,
Florian
next prev parent reply other threads:[~2021-03-15 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 10:03 Florian Weimer
2021-03-15 12:10 ` H.J. Lu
2021-03-15 12:14 ` Florian Weimer [this message]
2021-03-15 12:24 ` H.J. Lu
2021-03-15 12:28 ` Florian Weimer
2021-03-15 12:48 ` H.J. Lu
2021-03-15 12:55 ` Florian Weimer
2021-03-15 12:49 ` Andreas Schwab
2021-03-15 12:55 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rcgwr3y.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).