From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Cc: Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: Re: [PATCH 3/3] Build libc-start with stack protector for SHARED
Date: Wed, 10 Mar 2021 09:00:38 +0100 [thread overview]
Message-ID: <871rcnwi8p.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210309181259.2603144-4-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Tue, 9 Mar 2021 23:42:59 +0530")
* Siddhesh Poyarekar via Libc-alpha:
> This does not change the emitted code since __libc_start_main does not
> return, but is important for formal flags compliance.
>
> This also cleans up the cosmetic inconsistency in the stack protector
> flags in csu, especially the incorrect value of STACK_PROTECTOR_LEVEL.
> ---
> Makeconfig | 4 ++++
> csu/Makefile | 22 ++++++++++++----------
> elf/Makefile | 4 ----
> 3 files changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/Makeconfig b/Makeconfig
> index 0a4811b5e5..c99464fdfa 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -856,6 +856,10 @@ ifneq ($(stack-protector),)
> +stack-protector=$(stack-protector)
> endif
>
> +define elide-stack-protector
> +$(if $(filter $(@F),$(patsubst %,%$(1),$(2))), $(no-stack-protector))
> +endef
Please add a comment to this definition, now that it is available
everywhere. Okay with that change.
Thanks,
Florian
next prev parent reply other threads:[~2021-03-10 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 18:12 [PATCH 0/3] Clean up stack-protector-all build Siddhesh Poyarekar
2021-03-09 18:12 ` [PATCH 1/3] Build get-cpuid-feature-leaf.c without stack-protector Siddhesh Poyarekar
2021-03-10 7:58 ` Florian Weimer
2021-03-09 18:12 ` [PATCH 2/3] Disable stack protector for ifunc resolvers in tests Siddhesh Poyarekar
2021-03-10 7:59 ` Florian Weimer
2021-03-10 9:38 ` Siddhesh Poyarekar
2021-03-10 9:39 ` Florian Weimer
2021-03-10 9:57 ` Siddhesh Poyarekar
2021-03-09 18:12 ` [PATCH 3/3] Build libc-start with stack protector for SHARED Siddhesh Poyarekar
2021-03-10 8:00 ` Florian Weimer [this message]
2021-03-10 10:13 [PATCH v2 0/3] Clean up stack-protector-all build Siddhesh Poyarekar
2021-03-10 10:14 ` [PATCH 3/3] Build libc-start with stack protector for SHARED Siddhesh Poyarekar
2021-03-15 14:00 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rcnwi8p.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).