From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id ECF8B385EC55 for ; Thu, 21 Jan 2021 13:57:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ECF8B385EC55 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-1lvs5J5hOHmO_YQSjanMbA-1; Thu, 21 Jan 2021 08:57:13 -0500 X-MC-Unique: 1lvs5J5hOHmO_YQSjanMbA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 302B7800D55; Thu, 21 Jan 2021 13:57:12 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-35.ams2.redhat.com [10.36.113.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 270885D9C6; Thu, 21 Jan 2021 13:57:10 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Subject: Re: V4 [PATCH] : Remove the C preprocessor magic References: <20201225162451.1657088-1-hjl.tools@gmail.com> <87h7nc6ikc.fsf@oldenburg.str.redhat.com> <20210120144339.GA1866418@gmail.com> <87turb4n2x.fsf@oldenburg.str.redhat.com> <87lfcmzgdv.fsf@oldenburg.str.redhat.com> Date: Thu, 21 Jan 2021 14:57:09 +0100 In-Reply-To: (H. J. Lu via Libc-alpha's message of "Thu, 21 Jan 2021 05:29:20 -0800") Message-ID: <871reewfyi.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 13:57:17 -0000 * H. J. Lu via Libc-alpha: > Here is the updated patch to place __x86_get_cpuid_feature_leaf > in libc. OK for master? This version looks okay to me. We should perhaps document more of the interface in the manual, but we can discuss this separately. And I want to see the code changes go in for release testing now. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill