From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x32: Add <fixup-asm-unistd.h> and regenerate arch-syscall.h
Date: Wed, 26 Aug 2020 11:35:14 +0200 [thread overview]
Message-ID: <871rjt4unh.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOry6UZrBn4crSf2muPdA4TTgbBOrAwgnSsfZeMyeLNppA@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Tue, 25 Aug 2020 05:51:29 -0700")
* H. J. Lu via Libc-alpha:
> diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/Makefile b/sysdeps/unix/sysv/linux/x86_64/x32/Makefile
> index 16b768d8ba..2cd35c120b 100644
> --- a/sysdeps/unix/sysv/linux/x86_64/x32/Makefile
> +++ b/sysdeps/unix/sysv/linux/x86_64/x32/Makefile
> @@ -3,6 +3,8 @@ default-abi := x32
>
> ifeq ($(subdir),misc)
> sysdep_routines += arch_prctl
> +
> +tests-internal += tst-set_thread_area
> endif
I do not think the test is valuable. I just added it to show that
things do actually compile with older Linux headers because you didn't
believe me. 8-)
> diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h b/sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h
> new file mode 100644
> index 0000000000..01d1f448ca
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h
> +/* X32 uses the same 64-bit syscall interface for set_thread_area. */
> +#ifndef __NR_set_thread_area
> +# define __NR_set_thread_area 1073742029
> +#endif
I think the comment should reference the Linux version in which the
missing system call was fixed.
Thanks,
Florian
next prev parent reply other threads:[~2020-08-26 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 21:31 [PATCH] x32: Add <asm/unistd_x32.h> " H.J. Lu
2020-08-24 11:17 ` Florian Weimer
2020-08-24 12:42 ` H.J. Lu
2020-08-24 13:22 ` Florian Weimer
2020-08-24 13:56 ` H.J. Lu
2020-08-24 17:17 ` Florian Weimer
2020-08-24 18:54 ` H.J. Lu
2020-08-24 19:10 ` Florian Weimer
2020-08-24 19:29 ` H.J. Lu
2020-08-25 10:50 ` Florian Weimer
2020-08-25 12:51 ` [PATCH] x32: Add <fixup-asm-unistd.h> " H.J. Lu
2020-08-26 9:35 ` Florian Weimer [this message]
2020-08-27 13:36 ` H.J. Lu
2020-08-31 12:56 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rjt4unh.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).