From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 12B973857C53 for ; Mon, 24 Aug 2020 17:17:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 12B973857C53 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-0bgYGhHQMnOAx2ruPOdydA-1; Mon, 24 Aug 2020 13:17:26 -0400 X-MC-Unique: 0bgYGhHQMnOAx2ruPOdydA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 802FA100670A; Mon, 24 Aug 2020 17:17:25 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D201B10021AA; Mon, 24 Aug 2020 17:17:24 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH] x32: Add and regenerate arch-syscall.h References: <20200815213138.1375595-1-hjl.tools@gmail.com> <87v9h8e1it.fsf@oldenburg2.str.redhat.com> <87imd8dvpr.fsf@oldenburg2.str.redhat.com> Date: Mon, 24 Aug 2020 19:17:23 +0200 In-Reply-To: (H. J. Lu's message of "Mon, 24 Aug 2020 06:56:29 -0700") Message-ID: <871rjwdkv0.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 17:17:36 -0000 * H. J. Lu: > On Mon, Aug 24, 2020 at 6:23 AM Florian Weimer wrote= : >> >> * H. J. Lu: >> >> > It doesn't work in this case. is used to undefin= e or >> > redefine a syscall from . The actual syscall numbers s= till >> > come from . In this case, the sycall number is missing = from >> > . My patch is a prerequisite for a new testcase: >> > >> > ../sysdeps/unix/sysv/linux/x86/tst-sigreturn-1.c: In function =E2=80= =98setup_ldt=E2=80=99: >> > ../sysdeps/unix/sysv/linux/x86/tst-sigreturn-1.c:258:14: error: >> > =E2=80=98SYS_set_thread_area=E2=80=99 undeclared (first use in this fu= nction) >> > 258 | if (syscall(SYS_set_thread_area, &gdt_data16_desc) =3D=3D 0) = { >> > | ^~~~~~~~~~~~~~~~~~~ >> >> Can you make it an internal test and use __NR_set_thread_area? >> > > Like? > > #if !defined(__NR_set_thread_area) && defined(__x86_64__) && defined(__IL= P32__) > /* X32 uses the same 64-bit syscall interface for set_thread_area. */ > # define __NR_set_thread_area (__X32_SYSCALL_BIT + 205) > #endif No, I neant using tests-internal, so that you get the built-in system call table. But is it really correct to add an unsupported system call definition for the rest of glibc? If this is just setting things up for a test, maybe the __X32_SYSCALL_BIT hack is the right approach after all. (I don't know the objective of this test.) Thanks, Florian