From: Florian Weimer <fweimer@redhat.com>
To: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] linux: wait4: Fix incorrect return value comparison
Date: Thu, 09 Apr 2020 17:35:57 +0200 [thread overview]
Message-ID: <871rowr7s2.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAKmqyKODM6i6pqt4TScrF+o=JvZF6ncwmx=1SxkyYEKBcxYPbg@mail.gmail.com> (Alistair Francis via Libc-alpha's message of "Tue, 7 Apr 2020 07:47:42 -0700")
* Alistair Francis via Libc-alpha:
> On Tue, Apr 7, 2020 at 6:25 AM Adhemerval Zanella via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>>
>>
>> On 07/04/2020 08:23, Florian Weimer via Libc-alpha wrote:
>> > * Alistair Francis via Libc-alpha:
>> >
>> >> Path 600f00b "linux: Use long time_t for wait4/getrusage" introduced
>> >
>> > Typo: "Path"
>> >
>> >> two bugs:
>> >> - The usage32 struct was set if the wait4 syscall had an error.
>> >> - For 32-bit systems the usage struct was set even if it was specified
>> >> as NULL.
>> >>
>> >> This patch fixes the two issues.
>> >
>> > Would it make sense to include a test case?
>> >
>> > (Somehow, my earlier message did not make it it to the list.)
>>
>> I think it would, specially now that glibc does more internally.
>
> I agree.
>
> Would you like me to write it or does someone who knows more about the
> glibc tests like to do it?
It looks like we should commit the patch sooner than later.
We can work on the test case next week. Either I can teach you to how
to write it, or I can write it myself.
Would you please post a v3 with just the indentation fixes?
Thanks,
Florian
next prev parent reply other threads:[~2020-04-09 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 5:40 Alistair Francis
2020-04-07 7:35 ` Andreas Schwab
2020-04-07 11:23 ` Florian Weimer
2020-04-07 13:24 ` Adhemerval Zanella
2020-04-07 14:47 ` Alistair Francis
2020-04-09 15:35 ` Florian Weimer [this message]
2020-04-09 15:41 ` Adhemerval Zanella
2020-04-09 20:13 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rowr7s2.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).