From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-107703-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 129642 invoked by alias); 4 Dec 2019 07:31:31 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 128689 invoked by uid 89); 4 Dec 2019 07:31:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: us-smtp-delivery-1.mimecast.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1575444687;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1hzUHwwy4lDsPzZXczWjNN21zKaPIPiq+w+SgEUIwwY=;
	b=hIKDOBI0HMAZhOVMC4erfOnbRnkRFHRpkIkk6vaalr8saoVQXbB8RgjtnjZnaEuO9nGUVn
	To0s6AN32EcQUSkXWPZPTnhChRuquA+ye6s0mk5jsMdLfQ7JZ0lw9CilJe5L5vhMopR4xW
	0XappJfkJ9uhOGOCC1GY5NXGajLX+6c=
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Fix build with -march=486 -Os -DNDEBUG (Bug 25240)
References: <9e41bfdd-c2e6-9fcd-9576-d485aba0d401@redhat.com>
	<875zixqe7d.fsf@oldenburg2.str.redhat.com>
	<7f4d3a93-e140-5125-5247-52b86dcb6247@redhat.com>
Date: Wed, 04 Dec 2019 07:31:00 -0000
In-Reply-To: <7f4d3a93-e140-5125-5247-52b86dcb6247@redhat.com> (Carlos
	O'Donell's message of "Tue, 3 Dec 2019 17:01:44 -0500")
Message-ID: <871rtkr1h5.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2019-12/txt/msg00135.txt.bz2

* Carlos O'Donell:

> How is this v2 with a better commit message?

Sorry, why has -DNDEBUG got anything with -march=3Di486 (sic) or -Os?
I think you should mention -DNDEBUG only.

The comment should probably mention CFLAGS and -DNDEBUG, because that's
the common case.

Thanks,
Florian