From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86012 invoked by alias); 9 Jan 2019 14:05:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 85999 invoked by uid 89); 9 Jan 2019 14:05:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com From: Florian Weimer To: Andreas Schwab Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Fix handling of collating elements in fnmatch (bug 17396, bug 16976) References: <87zhscfq0h.fsf@oldenburg2.str.redhat.com> Date: Wed, 09 Jan 2019 14:05:00 -0000 In-Reply-To: (Andreas Schwab's message of "Wed, 09 Jan 2019 14:20:38 +0100") Message-ID: <871s5msz8g.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00205.txt.bz2 * Andreas Schwab: > On Jan 07 2019, Florian Weimer wrote: > >>> + /* Compare the wide char sequence. */ >>> + && memcmp (startp + 1, &wextra[1], >>> + c1 * sizeof (UCHAR)) == 0) >> >> Could this use wmemcmp? > > That required adding an internal alias. Oh, sorry, I didn't realize we were missing that. I believe that due to the freeze, we should go with the original patch then. Thanks, Florian